-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for value in documentation #2167
base: main
Are you sure you want to change the base?
Conversation
Update exported_fields.go - Add capability to write the value of a field as defined in the fields.yml to the Markdown documentation
/test |
I added to to PR the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This approach looks better to me, I have added some questions and suggestions, let me know what you think.
/test |
@stevengoossensB CI is failing for some formatting issue. Try running |
/test |
This reverts commit 4ed69a6.
/test |
💔 Build Failed
Failed CI Steps
History
|
@jsoriano can you elaborate on why the tests are still failing as I don't have visibility on that. |
It looks like the change from spec 1.0.0 to 3.4.0 in the nginx package is triggering many validation issues. You can see them with:
I would suggest to test this with some test package that is already using a 3.X spec version. For example try increasing the
And commit the changes. |
I reverted the changes for NGINX and upgraded Anomali. |
Update exported_fields.go - Add capability to write the value of a field as defined in the fields.yml to the Markdown documentation