-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacetime: Add traces into elastic-package commands using OTel #2247
Closed
+1,216
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
History
cc @mrodm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of OTel instrumentation to send traces to a target cluster using the autoexport package from OTEL.
It has been added a global span for each command, but just the following commands have been instrumented with specific spans:
If there is no environment variable defined, the telemetry is disabled by setting the following environment variables in the code:
Pending:
Screenshots
Example of the trace got running
elastic-package test system
:How to test locally
Steps to start a local cluster with the required features (APM):
stack.apm_enabled: true
~/.elastic-package/profiles/default/config.yml
elastic-package
service under APM viewelastic-package
in a shell session without the environment variables there should not be any failure.