Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review tear down test system handlers #2252

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Dec 2, 2024

This PR revisits the handlers run in the Tear Down test process for the system tests.

When using independent Elastic Agents for each test scenario, the following handlers can be skipped:

  • Reassign policy back to the Elastic Agent
  • Reset the log level to the Elastic Agent

When using independent Elastic Agents, those agents are going to be removed/uninstalled at the end of the test, so there is no need to run those two handlers. There is a special case where it needs to be kept the reassignment of the policy when using the --no-provision flag in system tests.

@mrodm mrodm self-assigned this Dec 2, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mrodm

@mrodm mrodm marked this pull request as ready for review December 3, 2024 12:17
@mrodm mrodm requested a review from a team December 3, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants