Justin black jupyter test #507
Closed
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed specific Python version specification.
|
Review these changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/507 |
Contributor
Author
|
@carlyrichmond this is the PR to update jupyter-black. The pre-commit tests in this PR are showing success w/ the version bump. |
Contributor
|
Superseded by #515 (which also updates it to the new org under the PSF) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps our pre-commit/actions to use the latest version of black-jupyter (25.11.0)
Version 24.1.1 is breaking during the pre-commit/actions black-jupyter check on notebooks. This is patched with pinning the Python version that uses black-jupyter @3.13, but best practice would be to update black-jupyter, as our global version is 3.14.
Made a small change to a notebook to test the pre-commit.