Skip to content

Commit

Permalink
Revert fail-fast disconnect strategy for _resolve/cluster (#124241) (
Browse files Browse the repository at this point in the history
…#124368)

* Revert fail-fast disconnect strategy for `_resolve/cluster`

This was the first solution for the long wait times that user could
potentially see when invoking this API. However, we reverted this change
in favour of the new timeout parameter. Unfortunately, the change in
disconnect strategy targeted more broader versions than the timeout
parameter PR (which contained the revert). This PR fixes this discrepancy.

* Update docs/changelog/124241.yaml
  • Loading branch information
pawankartik-elastic authored Mar 7, 2025
1 parent c14ccdb commit 521ebfa
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions docs/changelog/124241.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 124241
summary: Revert fail-fast disconnect strategy for `_resolve/cluster`
area: Search
type: bug
issues: []
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ protected void doExecuteForked(Task task, ResolveClusterActionRequest request, A
RemoteClusterClient remoteClusterClient = remoteClusterService.getRemoteClusterClient(
clusterAlias,
searchCoordinationExecutor,
RemoteClusterService.DisconnectedStrategy.FAIL_IF_DISCONNECTED
RemoteClusterService.DisconnectedStrategy.RECONNECT_IF_DISCONNECTED
);
var remoteRequest = new ResolveClusterActionRequest(originalIndices.indices(), request.indicesOptions());
// allow cancellation requests to propagate to remote clusters
Expand Down

0 comments on commit 521ebfa

Please sign in to comment.