Enterprise GeoIp Task experiment #110207
Draft
Enterprise GeoIp Task experiment #110207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
the
:Data Management/Ingest Node
…ersistentTaskExecutor
…rpriseGeoIpDownloaderTaskExecutor
joegallo
reviewed
Jun 27, 2024
| @@ -16,4 +16,5 @@ | |||
| requires com.maxmind.db; | |||
|
|
|||
| exports org.elasticsearch.ingest.geoip.stats to org.elasticsearch.server; | |||
| exports org.elasticsearch.ingest.geoip.enterprise; | |||
There was a problem hiding this comment.
Is there some to [...] that could go here that would work?
this lets us tighten the binding on the export side to say that we're only exporting this weird stuff into the enterprise downloader, which feels a little like a tidy wormhole for us to ship code through.
This is a little more direct, but it requires that we put the code that needs to be on both sides of the aisle into server, rather than exporting code from the ingest-geoip module out into the license-aware side of the house. I'm keeping this here just as a WIP commit to give us a view of the two sides at the same time -- we really could do it either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT