More debug logging in realms authenticator #124342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1v0lg
added
>non-issue
:Security/Authentication
…com:n1v0lg/elasticsearch into debug-log-request-processing-failures-authc
|
Pinging @elastic/es-security (Team:Security) |
jakelandis
approved these changes
Mar 7, 2025
| @@ -252,6 +252,14 @@ private void consumeToken(Context context, ActionListener<AuthenticationResult<A | |||
| listener.onFailure(context.getRequest().authenticationFailed(authenticationToken)); | |||
| } else { | |||
| assert e instanceof AuthenticationTerminatedSuccessfullyException == false : e; | |||
| logger.debug( | |||
| () -> format( | |||
| "An error occurred while attempting to authenticate [%s] with token [%s]", | |||
There was a problem hiding this comment.
nit: s/token/token of type
…com:n1v0lg/elasticsearch into debug-log-request-processing-failures-authc
n1v0lg
added
the
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds debug logging to the realms authenticator, for exceptions around request processing.