[ML] Initialize backing indices before running integration test #137122
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner
changed the title
DonalEvans
reviewed
Oct 24, 2025
Comment on lines
197
to
200
| public void testMultipleInferencesTriggeringDownloadAndDeploy() throws InterruptedException, IOException { | ||
| // Creating an inference endpoint to force the backing indices to be created to reduce the likelihood of the test failing | ||
| // because it's trying to interact with the indices while they're being created. | ||
| putModel("initial-model", mockCompletionServiceModelConfig(TaskType.SPARSE_EMBEDDING, "streaming_completion_test_service")); |
There was a problem hiding this comment.
If you delete this endpoint right after creating it, will the backing indices still exist? If so, it would be cleaner to create then delete the endpoint so that you don't need to account for an extra endpoint hanging around in other tests.
There was a problem hiding this comment.
Yeah I'll give that a shot 👍
…/elasticsearch into ml-fix-default-it-tests
DonalEvans
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue: #117208
The test is trying to download and deploy the elser model and it is also persisting an inference endpoint while doing that.
This fix tries to force the backing indices to be created by persisting a model before we try executing multiple elser requests.