Rename UnassignedInfo#AllocationStatus to #FailedAllocationStatus #137136
Conversation
DiannaHohensee
added
>non-issue
:Distributed Coordination/Allocation
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
| * | ||
| * Note, ordering of the enum is important, make sure to add new values | ||
| * at the end and handle version serialization properly. | ||
| */ |
There was a problem hiding this comment.
Here's the comment explaining that these are unsuccessful allocation attempts.
There are a LOT of allocation status enums. This name better represents the meaning, as there are no successful enum values. Relates ES-12729
DiannaHohensee
force-pushed
the
2025/10/24/ES-12729-refactor
branch
from
606133c to
d21c5d1
Compare
elasticsearchmachine
added
the
serverless-linked
| * at the end and handle version serialization properly. | ||
| */ | ||
| public enum AllocationStatus implements Writeable { | ||
| public enum FailedAllocationStatus implements Writeable { |
There was a problem hiding this comment.
FailedAllocationStatus contradicts some of the variants: FETCHING_SHARD_DATA, DELAYED_ALLOCATION, NO_ATTEMPT, those are not failures. I don't find existing name hard to understand. For me more confusing having Reason and AllocationStatus as two different enums, where AllocationStatus is partially a reason why shard is un-assigned, while Reason is some context of assignment.
There was a problem hiding this comment.
I agree. My interpretation of the two fields is:
Reasonis why the shard becomes unassigned in the first place.AllocationStatusis why the shard remains unassigned after attempt to assign it. It can beNO_ATTEMPTif this has not happend yet.
Also, failed allocation has a different meaning, i.e. the shard failed after being allocated to a data node. The fields UnassignedInfo.failedAllocations, UnassignedInfo.failure and UnassignedInfo.failedNodeIds are used for this scenario.
There was a problem hiding this comment.
Oh damn, I didn't even see UnassignedInfo#Reason 😵
4 participants
There are a LOT of allocation status enums.
This name better represents the meaning,
as there are no successful enum values.
Relates ES-12833
Simple IntelliJ aided rename, but lots of files. Left a comment on the source point for the rename.