Fix mutateInstance() imlementations in inference module #137138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonalEvans
added
>test
|
Pinging @elastic/ml-core (Team:ML) |
dimitris-athanasiou
requested changes
Oct 29, 2025
...ce/src/test/java/org/elasticsearch/xpack/inference/common/amazon/AwsSecretSettingsTests.java
Outdated
Show resolved
Hide resolved
...nference/services/azureaistudio/completion/AzureAiStudioChatCompletionTaskSettingsTests.java
Outdated
Show resolved
Hide resolved
...ack/inference/services/azureopenai/completion/AzureOpenAiCompletionServiceSettingsTests.java
Outdated
Show resolved
Hide resolved
| return randomValueOtherThan(instance, AzureOpenAiSecretSettingsTests::createRandom); | ||
| SecureString apiKey = instance.apiKey(); | ||
| SecureString entraId = instance.entraId(); | ||
| if (apiKey == null || entraId == null) { |
There was a problem hiding this comment.
As there is a constructor that accepts the args without doing validation, do we need the complicated logic here?
There was a problem hiding this comment.
I'm not seeing a constructor for AzureOpenAiSecretSettings that doesn't do the validation that both arguments aren't null. I could add one, but it doesn't seem like it's worth it just to make one test method slightly simpler.
There was a problem hiding this comment.
You're right, my eyes ignored Objects.requireNonNullElse(apiKey, entraId);
.../org/elasticsearch/xpack/inference/services/cohere/rerank/CohereRerankTaskSettingsTests.java
Outdated
Show resolved
Hide resolved
...ference/services/googlevertexai/embeddings/GoogleVertexAiEmbeddingsServiceSettingsTests.java
Outdated
Show resolved
Hide resolved
.../inference/services/googlevertexai/embeddings/GoogleVertexAiEmbeddingsTaskSettingsTests.java
Outdated
Show resolved
Hide resolved
...csearch/xpack/inference/services/openai/embeddings/OpenAiEmbeddingsServiceSettingsTests.java
Outdated
Show resolved
Hide resolved
chrisparrinello
pushed a commit
to chrisparrinello/elasticsearch
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134166