fix field def from #704 #707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzl
requested review from
ashokaditya,
ferullo,
joeypoon,
ricardo-estc,
soolidsnake and
szwarckonrad
and removed request for
szwarckonrad
1 task
ferullo
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
PR #704 added some fields, and after review comments,
Ext.script.contentwas edited to bematch_only_text, but it was manually edited in the output file,package/endpoint/data_stream/process/fields/fields.ymland not the input field source field incustom_schemas/custom_process.yml.So further runs of
makewould overwrite the field, going back to the source file which defined it askeywordstill.Details
This wasn't caught in the PR itself because of how the
makeprereqs are defined. At the point that the output file (fields.yml) was edited, wouldn't trigger make to run. It is not a prereq file for anything. Make would decide there is "nothing to do" since everything was up-to-date. Editing output files would escape being overwritten in that PR.Only when a subsequent change gets made to the related input file (
custom_process.yml) would thatmakerecipe run, and overwrite the field.Luckily, another PR did make a related change, the file was overwritten, and CI then caught the diff occurring.
Updates should be made in the future for
maketo run in more cases, e.g. if the output files were their own prereqs.