Skip to content

[Redis] Add and update metrics fields for Redis 7.x and 8.x #16732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
giorgi-imerlishvili-elastic wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[Redis] Add and update metrics fields for Redis 7.x and 8.x #16732

giorgi-imerlishvili-elastic wants to merge 7 commits into from
+583 −257

Conversation

@giorgi-imerlishvili-elastic
Copy link
Contributor

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic commented Dec 30, 2025 •
edited
Loading

Proposed commit message

Add and update metrics fields for Redis 7.x and 8.x
Add system test for info data stream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic requested a review from a team as a code owner December 30, 2025 17:02
@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic added the enhancement New feature or request label Dec 30, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Dec 30, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

mykola-elastic
mykola-elastic reviewed Jan 7, 2026
View reviewed changes
mykola-elastic
mykola-elastic reviewed Jan 7, 2026
View reviewed changes
packages/redis/data_stream/keyspace/_dev/test/system/test-default-config.yml
Comment on lines +6 to +8
skip:
reason: Test is skipped for now since it will fail on Redis 7.x and 8.x due to the issue #43887
link: https://github.com/elastic/beats/issues/43887 No newline at end of file
Copy link
Contributor

@mykola-elastic mykola-elastic Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you fix this in elastic/beats#47971 ? Why skipping?

Copy link
Contributor Author

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-elastic I merged that PR yesterday, it's merged in main branch. Doesn't it need some time to apply to the SANPSHOTS which are used for development and in CI?

Copy link
Contributor

@mykola-elastic mykola-elastic Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar PR to this one: https://github.com/elastic/integrations/pull/16680/files

It adds the field which was added and backported to beats but it updated the kibana.version. (See PR description and changes).
So, basically, it seems that you have to change kibana.version too to the latest as the subexpiry was only added to the main.

Also, we might need to backport the PR elastic/beats#47971 too?

Is my logic correct @ishleenk17 @shmsr ?

@elasticmachine
Copy link

elasticmachine commented Jan 7, 2026

💚 Build Succeeded

History

cc @giorgi-imerlishvili-elastic

@andrewkroh andrewkroh added Integration:redis Redis documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mykola-elastic mykola-elastic mykola-elastic left review comments

@jakubgalecki0 jakubgalecki0 jakubgalecki0 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@giorgi-imerlishvili-elastic giorgi-imerlishvili-elastic

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:redis Redis Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@giorgi-imerlishvili-elastic @elasticmachine @mykola-elastic @jakubgalecki0 @andrewkroh