Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[microsoft_dnsserver] Initial release of Microsoft DNS Server integration #9722

Merged
merged 6 commits into from
May 17, 2024
Merged

[microsoft_dnsserver] Initial release of Microsoft DNS Server integration #9722

merged 6 commits into from
May 17, 2024

Conversation

chemamartinez
Copy link
Contributor

Proposed commit message

Add a new package to collect audit and analytical events for Microsoft DNS Server.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Integration release checklist

This checklist is intended for integrations maintainers to ensure consistency
when creating or updating a Package, Module or Dataset for an Integration.

All changes

  • Change follows the contributing guidelines
  • Supported versions of the monitoring target are documented
  • Supported operating systems are documented (if applicable)
  • Integration or System tests exist
  • Documentation exists, useful guidelines to follow
  • Fields follow ECS and naming conventions
  • At least a manual test with ES / Kibana / Agent has been performed.
  • Required Kibana version set to: 8.13.0

New Package

  • Screenshot of the "Add Integration" page on Fleet added

Dashboards changes

  • Dashboards exists
  • Screenshots added or updated
  • Datastream filters added to visualizations

Log dataset changes

  • Pipeline tests exist (if applicable)
  • Generated output for at least 1 log file exists
  • Sample event (sample_event.json) exists

Note: Pending on elastic/elastic-package#1527 to add system tests and sample events.

Related issues

Screenshots

Integration page

Screenshot 2024-04-26 at 15 31 26 Screenshot 2024-04-26 at 15 45 08

Configuration

Add-integration-Microsoft-DNS-Server-Integrations-Elastic

Analytical dashboard

dashboard-microsoft_dnsserver-analytics

Audit dashboard

dashboard-microsoft_dnsserver-audit

@chemamartinez chemamartinez added enhancement New feature or request New Integration Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform] Integration:microsoft_dnsserver Microsoft DNS Server labels Apr 26, 2024
@chemamartinez chemamartinez self-assigned this Apr 26, 2024
@chemamartinez chemamartinez marked this pull request as ready for review April 26, 2024 14:02
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@chemamartinez chemamartinez requested review from a team May 2, 2024 08:43
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

efd6
efd6 reviewed May 8, 2024
View reviewed changes
packages/microsoft_dnsserver/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/microsoft_dnsserver/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/microsoft_dnsserver/_dev/build/docs/README.md Show resolved Hide resolved
...microsoft_dnsserver/data_stream/analytical/_dev/test/pipeline/test-events.json-expected.json Outdated Show resolved Hide resolved
packages/microsoft_dnsserver/data_stream/analytical/fields/fields.yml Outdated Show resolved Hide resolved
packages/microsoft_dnsserver/data_stream/analytical/elasticsearch/ingest_pipeline/default.yml Show resolved Hide resolved
packages/microsoft_dnsserver/data_stream/analytical/elasticsearch/ingest_pipeline/default.yml Show resolved Hide resolved
packages/microsoft_dnsserver/data_stream/analytical/manifest.yml Show resolved Hide resolved
packages/microsoft_dnsserver/data_stream/audit/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
packages/microsoft_dnsserver/data_stream/audit/elasticsearch/ingest_pipeline/default.yml Outdated Show resolved Hide resolved
@chemamartinez chemamartinez requested review from kcreddy and efd6 May 13, 2024 18:36
kcreddy
kcreddy approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for my comments.

marc-gr
marc-gr approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@marc-gr marc-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would just remove the unnecessary error check exceptions

packages/microsoft_dnsserver/validation.yml Outdated Show resolved Hide resolved
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chemamartinez

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
92.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@chemamartinez chemamartinez merged commit 7466bb6 into main May 17, 2024
5 checks passed
@chemamartinez chemamartinez deleted the new-dnsserver-integration branch May 17, 2024 11:45
@elasticmachine
Copy link

Package microsoft_dnsserver - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_dnsserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

@marc-gr marc-gr marc-gr approved these changes

@kcreddy kcreddy kcreddy approved these changes

Assignees

@chemamartinez chemamartinez

Labels
enhancement New feature or request Integration:microsoft_dnsserver Microsoft DNS Server New Integration Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] Team:Security-Windows Platform Security Windows Platform Team [elastic/sec-windows-platform]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Windows] DNS Analytical and Audit event support
5 participants
@chemamartinez @elasticmachine @kcreddy @marc-gr @efd6