Skip to content

Commit

Permalink
Remove core properties from ShareMenuItemV2
Browse files Browse the repository at this point in the history
  • Loading branch information
tsullivan committed Nov 25, 2024
1 parent 2e004f8 commit da4dd34
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
4 changes: 0 additions & 4 deletions src/plugins/share/public/components/context/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

import { ThemeServiceSetup } from '@kbn/core-theme-browser';
import { I18nStart } from '@kbn/core/public';
import React, { type PropsWithChildren, createContext, useContext } from 'react';

import { AnonymousAccessServiceContract } from '../../../common';
Expand All @@ -29,8 +27,6 @@ export interface IShareContext extends ShareContext {
anonymousAccess?: AnonymousAccessServiceContract;
urlService: BrowserUrlService;
snapshotShareWarning?: string;
theme: ThemeServiceSetup;
i18n: I18nStart;
publicAPIEnabled?: boolean;
anchorElement?: HTMLElement;
}
Expand Down
2 changes: 0 additions & 2 deletions src/plugins/share/public/services/share_menu_manager.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ export class ShareMenuManager {
onClose();
unmount();
},
theme,
i18n,
}}
/>,
{ i18n, theme }
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/share/public/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import type { ComponentType, ReactElement } from 'react';
import type { InjectedIntl } from '@kbn/i18n-react';
import { EuiContextMenuPanelDescriptor } from '@elastic/eui';
import { EuiContextMenuPanelItemDescriptorEntry } from '@elastic/eui/src/components/context_menu/context_menu';
import type { Capabilities, ThemeServiceSetup, ToastsSetup } from '@kbn/core/public';
import type { Capabilities, ToastsSetup } from '@kbn/core/public';
import type { UrlService, LocatorPublic } from '../common/url_service';
import type { BrowserShortUrlClientFactoryCreateParams } from './url_service/short_urls/short_url_client_factory';
import type { BrowserShortUrlClient } from './url_service/short_urls/short_url_client';
Expand Down Expand Up @@ -127,7 +127,7 @@ export interface ShareMenuItemV2 extends ShareMenuItemBase {
* Not applicable for exports that do not call a remote API (i.e Lens CSV export)
*/
generateExportUrl?: (args: ScreenshotExportOpts) => string | undefined;
theme?: ThemeServiceSetup;
theme?: null;
renderLayoutOptionSwitch?: boolean;
layoutOption?: 'print';
generateCopyUrl?: URL;
Expand Down

0 comments on commit da4dd34

Please sign in to comment.