Visualizing composite spans. #106862
Merged
Visualizing composite spans. #106862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
|
This PR basically extracts just the visualization part (excluding the complex compressed spans algorithm) from #97438 |
.../transaction_details/waterfall_with_summary/waterfall_container/Waterfall/waterfall_item.tsx
Outdated
Show resolved
Hide resolved
.../transaction_details/waterfall_with_summary/waterfall_container/Waterfall/waterfall_item.tsx
Outdated
Show resolved
Hide resolved
.../transaction_details/waterfall_with_summary/waterfall_container/Waterfall/waterfall_item.tsx
Outdated
Show resolved
Hide resolved
.../transaction_details/waterfall_with_summary/waterfall_container/Waterfall/waterfall_item.tsx
Outdated
Show resolved
Hide resolved
.../transaction_details/waterfall_with_summary/waterfall_container/Waterfall/waterfall_item.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/shared/Summary/CompositeSpanDurationSummaryItem.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/shared/Summary/CompositeSpanDurationSummaryItem.tsx
Outdated
Show resolved
Hide resolved
cauemarcondes
requested changes
Jul 27, 2021
smith
reviewed
Jul 27, 2021
...ansaction_details/waterfall_with_summary/waterfall_container/Waterfall/span_flyout/index.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
cauemarcondes
pushed a commit
to cauemarcondes/kibana
that referenced
this pull request
Aug 5, 2021
* Visualizing composite spans. * fixed reviews comments * replaced var usage with let * Fixed display of compositeSpanDurationSummary Co-authored-by: Kibana Machine <[email protected]>
cauemarcondes
added a commit
that referenced
this pull request
Aug 5, 2021
* Visualizing composite spans. * fixed reviews comments * replaced var usage with let * Fixed display of compositeSpanDurationSummary Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Alexander Wert <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
* Visualizing composite spans. * fixed reviews comments * replaced var usage with let * Fixed display of compositeSpanDurationSummary Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With elastic/apm-server#5661, the APM server is capable of receiving composite spans from APM agents and storing them in Elasticsearch.
This PR provides the corresponding visualization in the Waterfall and SpanFlyout for composite spans:
Checklist
Delete any items that are not applicable to this PR.
For maintainers