[Security Solution] Enable the feature flag for JSON diffing in prebuilt rules #173368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitaindik
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
banderror
approved these changes
Dec 18, 2023
|
I'm planning to merge this PR today or tomorrow after the ongoing deployment to Serverless finishes. |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @nikitaindik |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 21, 2023
…ilt rules (elastic#173368) **Ticket:** elastic#169160 ## Summary Sets the `jsonPrebuiltRulesDiffingEnabled` to `true` to enable the new "Updates" tab in prebuilt rules flyout. ### IMPORTANT: Merge only once acceptance and exploratory testing are passed! <img width="1178" alt="Schermafbeelding 2023-12-13 om 17 37 07" src="https://github.com/elastic/kibana/assets/15949146/9e07e069-595f-49a6-98c2-d2ed4aa3f977"> Co-authored-by: Georgii Gorbachev <[email protected]> (cherry picked from commit d7b99a5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 21, 2023
…n prebuilt rules (#173368) (#173822) # Backport This will backport the following commits from `main` to `8.12`: - [[Security Solution] Enable the feature flag for JSON diffing in prebuilt rules (#173368)](#173368) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-21T11:39:16Z","message":"[Security Solution] Enable the feature flag for JSON diffing in prebuilt rules (#173368)\n\n**Ticket:** https://github.com/elastic/kibana/issues/169160\r\n\r\n## Summary\r\n\r\nSets the `jsonPrebuiltRulesDiffingEnabled` to `true` to enable the new\r\n\"Updates\" tab in prebuilt rules flyout.\r\n\r\n### IMPORTANT: Merge only once acceptance and exploratory testing are\r\npassed!\r\n\r\n<img width=\"1178\" alt=\"Schermafbeelding 2023-12-13 om 17 37 07\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/9e07e069-595f-49a6-98c2-d2ed4aa3f977\">\r\n\r\nCo-authored-by: Georgii Gorbachev <[email protected]>","sha":"d7b99a587799e34c9534e4ba793aad65b4f78d55","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","v8.12.0","v8.13.0"],"number":173368,"url":"https://github.com/elastic/kibana/pull/173368","mergeCommit":{"message":"[Security Solution] Enable the feature flag for JSON diffing in prebuilt rules (#173368)\n\n**Ticket:** https://github.com/elastic/kibana/issues/169160\r\n\r\n## Summary\r\n\r\nSets the `jsonPrebuiltRulesDiffingEnabled` to `true` to enable the new\r\n\"Updates\" tab in prebuilt rules flyout.\r\n\r\n### IMPORTANT: Merge only once acceptance and exploratory testing are\r\npassed!\r\n\r\n<img width=\"1178\" alt=\"Schermafbeelding 2023-12-13 om 17 37 07\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/9e07e069-595f-49a6-98c2-d2ed4aa3f977\">\r\n\r\nCo-authored-by: Georgii Gorbachev <[email protected]>","sha":"d7b99a587799e34c9534e4ba793aad65b4f78d55"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173368","number":173368,"mergeCommit":{"message":"[Security Solution] Enable the feature flag for JSON diffing in prebuilt rules (#173368)\n\n**Ticket:** https://github.com/elastic/kibana/issues/169160\r\n\r\n## Summary\r\n\r\nSets the `jsonPrebuiltRulesDiffingEnabled` to `true` to enable the new\r\n\"Updates\" tab in prebuilt rules flyout.\r\n\r\n### IMPORTANT: Merge only once acceptance and exploratory testing are\r\npassed!\r\n\r\n<img width=\"1178\" alt=\"Schermafbeelding 2023-12-13 om 17 37 07\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/9e07e069-595f-49a6-98c2-d2ed4aa3f977\">\r\n\r\nCo-authored-by: Georgii Gorbachev <[email protected]>","sha":"d7b99a587799e34c9534e4ba793aad65b4f78d55"}}]}] BACKPORT--> Co-authored-by: Nikita Indik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #169160
Summary
Sets the
jsonPrebuiltRulesDiffingEnabledtotrueto enable the new "Updates" tab in prebuilt rules flyout.IMPORTANT: Merge only once acceptance and exploratory testing are passed!