Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.12] [Security Solution] Prebuilt rules diffing style adjustments (#173187) #173373

Merged
merged 1 commit into from
Dec 14, 2023
Merged

[8.12] [Security Solution] Prebuilt rules diffing style adjustments (#173187) #173373

merged 1 commit into from
Dec 14, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

@nikitaindik
[Security Solution] Prebuilt rules diffing style adjustments (elastic…
704f6ca 
…#173187)

**Resolves: elastic#173264
**Addresses: elastic#169160

## Summary
Tweaks diff styling so that it's more readable in both light and dark
modes.

---

#### Light mode
<img width="1178" alt="Scherm­afbeelding 2023-12-13 om 17 37 07"
src="https://github.com/elastic/kibana/assets/15949146/fe8620c7-407a-4355-8863-4a5a8e1425ea">

#### Dark mode
<img width="1174" alt="Scherm­afbeelding 2023-12-13 om 17 41 03"
src="https://github.com/elastic/kibana/assets/15949146/a8df3b88-a482-455f-91d3-5e08f1381b8c">

(cherry picked from commit 37af741)
@kibanamachine kibanamachine enabled auto-merge (squash) December 14, 2023 12:14
@kibanamachine kibanamachine mentioned this pull request Dec 14, 2023
Merged
@nikitaindik nikitaindik mentioned this pull request Dec 14, 2023
Closed
15 tasks
@kibanamachine kibanamachine merged commit df14319 into elastic:8.12 Dec 14, 2023
41 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4833 4834 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.1MB 13.1MB +1.3KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nikitaindik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@nikitaindik nikitaindik

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @kibana-ci @nikitaindik