Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Feature Flag Support for Cloud Security Posture Plugin #205438

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Omolola-Akinleye
Copy link
Contributor

@Omolola-Akinleye Omolola-Akinleye commented Jan 2, 2025

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Changes

  • Adds enableExperimental to server configSchema
  • Makes feature flags configurable via xpack.cloudSecurityPosture.enableExperimental in kibana.dev.yml
  • Implements ExperimentFeatureService.get() for accessing feature flags
  • Add passing initliaterContext to plugin in order to access our plugin config

Benefits

  • Avoids circular dependency with Security Solution useIsExperimentalFeatureEnabled and prop drilling feature flags from Fleet plugin PackagePolicyReplaceDefineStepExtensionComponentProps
  • Provides server-side configuration support
  • Enables pre-release feature testing
  • Creates centralized feature flag management

This allows controlled testing of new features before release through configuration rather than code changes.

@Omolola-Akinleye Omolola-Akinleye added enhancement New value added to drive a business result Team:Cloud Security Cloud Security team related v8.18.0 labels Jan 2, 2025
@Omolola-Akinleye Omolola-Akinleye self-assigned this Jan 2, 2025
@Omolola-Akinleye Omolola-Akinleye requested a review from a team as a code owner January 2, 2025 20:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@Omolola-Akinleye Omolola-Akinleye added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:enhancement labels Jan 2, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 3, 2025

💔 Build Failed

Failed CI Steps

History

cc @Omolola-Akinleye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) enhancement New value added to drive a business result release_note:enhancement Team:Cloud Security Cloud Security team related v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants