-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Clusters] Modify folder structure #205473
Merged
SoniaSanzV
merged 1 commit into
elastic:main
from
SoniaSanzV:remote_cluster/folder_structure
Jan 3, 2025
Merged
[Remote Clusters] Modify folder structure #205473
SoniaSanzV
merged 1 commit into
elastic:main
from
SoniaSanzV:remote_cluster/folder_structure
Jan 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoniaSanzV
added
Feature:CCR and Remote Clusters
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
release_note:skip
Skip the PR/issue when compiling release notes
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
labels
Jan 3, 2025
Pinging @elastic/kibana-management (Team:Kibana Management) |
SoniaSanzV
changed the title
[Remote Cluster] Modify folder structure
[Remote Clusters] Modify folder structure
Jan 3, 2025
mattkime
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 3, 2025
Part of elastic#199664 ## Summary As part of the work of the `Remote clusters: UX improvements` project I've changed a bit the folder structure and moved some files that are going to be used by more than one step. Since the PR will be large, I decided to create a PR only for the structure changes to avoid much noise in the main PR. The new structure will be as follows: ``` |-- x-pack/platform/plugins/private/remote_clusters/public/application/sections/components/ |-- remote_cluster_config_steps [new folder] |-- components [will be used for the common components for all the steps] |-- request_flyout.tsx [existing but moved here] |-- remote_cluster_form |-- remote_cluster_setup_trust ``` (cherry picked from commit d26ba8a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 3, 2025
# Backport This will backport the following commits from `main` to `8.x`: - [[Remote Clusters] Modify folder structure (#205473)](#205473) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sonia Sanz Vivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T14:25:35Z","message":"[Remote Clusters] Modify folder structure (#205473)\n\nPart of https://github.com/elastic/kibana/issues/199664\n\n## Summary\n\nAs part of the work of the `Remote clusters: UX improvements` project\nI've changed a bit the folder structure and moved some files that are\ngoing to be used by more than one step. Since the PR will be large, I\ndecided to create a PR only for the structure changes to avoid much\nnoise in the main PR. The new structure will be as follows:\n\n```\n|-- x-pack/platform/plugins/private/remote_clusters/public/application/sections/components/\n |-- remote_cluster_config_steps [new folder]\n |-- components [will be used for the common components for all the steps]\n |-- request_flyout.tsx [existing but moved here]\n |-- remote_cluster_form\n |-- remote_cluster_setup_trust\n ```","sha":"d26ba8a9f3333c2a40edcc7ad8204a6cba31594a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:CCR and Remote Clusters","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Remote Clusters] Modify folder structure","number":205473,"url":"https://github.com/elastic/kibana/pull/205473","mergeCommit":{"message":"[Remote Clusters] Modify folder structure (#205473)\n\nPart of https://github.com/elastic/kibana/issues/199664\n\n## Summary\n\nAs part of the work of the `Remote clusters: UX improvements` project\nI've changed a bit the folder structure and moved some files that are\ngoing to be used by more than one step. Since the PR will be large, I\ndecided to create a PR only for the structure changes to avoid much\nnoise in the main PR. The new structure will be as follows:\n\n```\n|-- x-pack/platform/plugins/private/remote_clusters/public/application/sections/components/\n |-- remote_cluster_config_steps [new folder]\n |-- components [will be used for the common components for all the steps]\n |-- request_flyout.tsx [existing but moved here]\n |-- remote_cluster_form\n |-- remote_cluster_setup_trust\n ```","sha":"d26ba8a9f3333c2a40edcc7ad8204a6cba31594a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205473","number":205473,"mergeCommit":{"message":"[Remote Clusters] Modify folder structure (#205473)\n\nPart of https://github.com/elastic/kibana/issues/199664\n\n## Summary\n\nAs part of the work of the `Remote clusters: UX improvements` project\nI've changed a bit the folder structure and moved some files that are\ngoing to be used by more than one step. Since the PR will be large, I\ndecided to create a PR only for the structure changes to avoid much\nnoise in the main PR. The new structure will be as follows:\n\n```\n|-- x-pack/platform/plugins/private/remote_clusters/public/application/sections/components/\n |-- remote_cluster_config_steps [new folder]\n |-- components [will be used for the common components for all the steps]\n |-- request_flyout.tsx [existing but moved here]\n |-- remote_cluster_form\n |-- remote_cluster_setup_trust\n ```","sha":"d26ba8a9f3333c2a40edcc7ad8204a6cba31594a"}}]}] BACKPORT--> Co-authored-by: Sonia Sanz Vivas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
Feature:CCR and Remote Clusters
release_note:skip
Skip the PR/issue when compiling release notes
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #199664
Summary
As part of the work of the
Remote clusters: UX improvements
project I've changed a bit the folder structure and moved some files that are going to be used by more than one step. Since the PR will be large, I decided to create a PR only for the structure changes to avoid much noise in the main PR. The new structure will be as follows: