Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution][Alerts table] Fix issue with multiple ip addresses in strings #209475

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

janmonschke
Copy link
Contributor

@janmonschke janmonschke commented Feb 4, 2025

Summary

Fixes #191767

Multiple IPs are now displayed as individual links, even in the case where multiple IPs are passed as a single string (e.g. 127.0.0.1,127.0.0.2). Clicking on an individual link will open the flyout correctly as well.

Screen.Recording.2025-02-05.at.13.51.56.mov

Checklist

@janmonschke janmonschke added release_note:fix Team:Threat Hunting:Investigations Security Solution Investigations Team backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development labels Feb 4, 2025
@janmonschke janmonschke self-assigned this Feb 4, 2025
@janmonschke janmonschke requested review from a team as code owners February 4, 2025 09:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@janmonschke janmonschke added the backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) label Feb 4, 2025
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, code LGTM and desk tested! While we need to improve the UI to better show the ellipsis and the values in the tooltip in both the alerts table and timeline (and probably other places as well), this is outside of this PR's scope.
Nice job, thanks for fixing this!

The content wrapper isn't need anymore and it prevented the ellipsis from working
@janmonschke
Copy link
Contributor Author

While we need to improve the UI to better show the ellipsis and the values in the tooltip in both the alerts table and timeline (...)

@PhilippeOberti Made the ellipsis work in a9bc4ce

@janmonschke
Copy link
Contributor Author

@elasticmachine merge upstream

@PhilippeOberti
Copy link
Contributor

While we need to improve the UI to better show the ellipsis and the values in the tooltip in both the alerts table and timeline (...)

@PhilippeOberti Made the ellipsis work in a9bc4ce

Tested! Works beautifully, nice job! We lost the tooltip but there was not any useful information in it anyway as it was not displaying the value... plus I checked and the user name, host name, rule name (basically the other links) don't have it either.
Awesome!

@janmonschke
Copy link
Contributor Author

We lost the tooltip but there was not any useful information (...)

Yeah, I should've specified that the wrapper wasn't used anymore and it was actually showing a tooltip when it was not used anywhere else in the table.

Copy link
Contributor

@kapral18 kapral18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 1 questions, thanks!

ip,
flowTarget = FlowTarget.source,
const NetworkDetailsLinkComponent: React.FC<NetworkDetailsLinkProps> = ({ ip, ...restProps }) => {
// We see that sometimes the `ip` is passed as a string value of "IP1,IP2".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the same happen for arrays, i.e. ["IP1,IP2", "IP3,IP4"]?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure to be honest. It's not something that I've seen before though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say, let's not make the code more complex. I don't think an array of string with multiple values like that is a situation that we need to handle...

@janmonschke janmonschke enabled auto-merge (squash) February 5, 2025 15:06
@janmonschke janmonschke merged commit dda5381 into elastic:main Feb 5, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13166188116

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.5MB 21.5MB +225.0B

History

cc @janmonschke

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 5, 2025
… in strings (elastic#209475)

## Summary

Fixes elastic#191767

Multiple IPs are now displayed as individual links, even in the case
where multiple IPs are passed as a single string (e.g.
`127.0.0.1,127.0.0.2`). Clicking on an individual link will open the
flyout correctly as well.

https://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit dda5381)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 5, 2025
… in strings (elastic#209475)

## Summary

Fixes elastic#191767

Multiple IPs are now displayed as individual links, even in the case
where multiple IPs are passed as a single string (e.g.
`127.0.0.1,127.0.0.2`). Clicking on an individual link will open the
flyout correctly as well.

https://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit dda5381)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 5, 2025
… in strings (elastic#209475)

## Summary

Fixes elastic#191767

Multiple IPs are now displayed as individual links, even in the case
where multiple IPs are passed as a single string (e.g.
`127.0.0.1,127.0.0.2`). Clicking on an individual link will open the
flyout correctly as well.

https://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit dda5381)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.16 Backport failed because of merge conflicts
8.17 Backport failed because of merge conflicts
8.18
8.x
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 209475

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 5, 2025
…dresses in strings (#209475) (#209907)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[SecuritySolution][Alerts table] Fix issue with multiple ip addresses
in strings (#209475)](#209475)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jan
Monschke","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-05T20:40:17Z","message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting:Investigations","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in
strings","number":209475,"url":"https://github.com/elastic/kibana/pull/209475","mergeCommit":{"message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209475","number":209475,"mergeCommit":{"message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6"}}]}]
BACKPORT-->

Co-authored-by: Jan Monschke <[email protected]>
kibanamachine added a commit that referenced this pull request Feb 5, 2025
…resses in strings (#209475) (#209908)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[SecuritySolution][Alerts table] Fix issue with multiple ip addresses
in strings (#209475)](#209475)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jan
Monschke","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-05T20:40:17Z","message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting:Investigations","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in
strings","number":209475,"url":"https://github.com/elastic/kibana/pull/209475","mergeCommit":{"message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209475","number":209475,"mergeCommit":{"message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6"}}]}]
BACKPORT-->

Co-authored-by: Jan Monschke <[email protected]>
kibanamachine added a commit that referenced this pull request Feb 5, 2025
…resses in strings (#209475) (#209909)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[SecuritySolution][Alerts table] Fix issue with multiple ip addresses
in strings (#209475)](#209475)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jan
Monschke","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-05T20:40:17Z","message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat
Hunting:Investigations","backport:prev-minor","backport:prev-major","v9.1.0"],"title":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in
strings","number":209475,"url":"https://github.com/elastic/kibana/pull/209475","mergeCommit":{"message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209475","number":209475,"mergeCommit":{"message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6"}}]}]
BACKPORT-->

Co-authored-by: Jan Monschke <[email protected]>
janmonschke added a commit to janmonschke/kibana that referenced this pull request Feb 6, 2025
… in strings (elastic#209475)

## Summary

Fixes elastic#191767

Multiple IPs are now displayed as individual links, even in the case
where multiple IPs are passed as a single string (e.g.
`127.0.0.1,127.0.0.2`). Clicking on an individual link will open the
flyout correctly as well.

https://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit dda5381)

# Conflicts:
#	x-pack/plugins/security_solution/public/timelines/components/formatted_ip/index.tsx
@janmonschke
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.17
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

janmonschke added a commit to janmonschke/kibana that referenced this pull request Feb 6, 2025
… in strings (elastic#209475)

## Summary

Fixes elastic#191767

Multiple IPs are now displayed as individual links, even in the case
where multiple IPs are passed as a single string (e.g.
`127.0.0.1,127.0.0.2`). Clicking on an individual link will open the
flyout correctly as well.

https://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit dda5381)

# Conflicts:
#	x-pack/plugins/security_solution/public/timelines/components/formatted_ip/index.tsx
janmonschke added a commit to janmonschke/kibana that referenced this pull request Feb 6, 2025
… in strings (elastic#209475)

## Summary

Fixes elastic#191767

Multiple IPs are now displayed as individual links, even in the case
where multiple IPs are passed as a single string (e.g.
`127.0.0.1,127.0.0.2`). Clicking on an individual link will open the
flyout correctly as well.

https://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit dda5381)

# Conflicts:
#	x-pack/plugins/security_solution/public/timelines/components/formatted_ip/index.tsx
@janmonschke
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

janmonschke added a commit that referenced this pull request Feb 6, 2025
…dresses in strings (#209475) (#209971)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[SecuritySolution][Alerts table] Fix issue with multiple ip addresses
in strings (#209475)](#209475)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jan
Monschke","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-05T20:40:17Z","message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Threat
Hunting:Investigations","backport:prev-minor","backport:prev-major","v8.18.0","v9.1.0","v8.19.0"],"title":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in
strings","number":209475,"url":"https://github.com/elastic/kibana/pull/209475","mergeCommit":{"message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209909","number":209909,"state":"MERGED","mergeCommit":{"sha":"67a7a2fc842fd3e7b3a361d5b080d7a9794c01cf","message":"[9.0]
[SecuritySolution][Alerts table] Fix issue with multiple ip addresses in
strings (#209475) (#209909)\n\n# Backport\n\nThis will backport the
following commits from `main` to `9.0`:\n- [[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses\nin strings
(#209475)](https://github.com/elastic/kibana/pull/209475)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Jan\nMonschke\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-02-05T20:40:17Z\",\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"Team:Threat\nHunting:Investigations\",\"backport:prev-minor\",\"backport:prev-major\",\"v9.1.0\"],\"title\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses
in\nstrings\",\"number\":209475,\"url\":\"https://github.com/elastic/kibana/pull/209475\",\"mergeCommit\":{\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/209475\",\"number\":209475,\"mergeCommit\":{\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Jan Monschke
<[email protected]>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209907","number":209907,"state":"MERGED","mergeCommit":{"sha":"7767ad87599a4d97027757e94abc7b9db1df3cd1","message":"[8.18]
[SecuritySolution][Alerts table] Fix issue with multiple ip addresses in
strings (#209475) (#209907)\n\n# Backport\n\nThis will backport the
following commits from `main` to `8.18`:\n- [[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses\nin strings
(#209475)](https://github.com/elastic/kibana/pull/209475)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Jan\nMonschke\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-02-05T20:40:17Z\",\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"Team:Threat\nHunting:Investigations\",\"backport:prev-minor\",\"backport:prev-major\",\"v9.1.0\"],\"title\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses
in\nstrings\",\"number\":209475,\"url\":\"https://github.com/elastic/kibana/pull/209475\",\"mergeCommit\":{\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/209475\",\"number\":209475,\"mergeCommit\":{\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Jan Monschke
<[email protected]>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209475","number":209475,"mergeCommit":{"message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209908","number":209908,"state":"MERGED","mergeCommit":{"sha":"e62eef171bec5fe025f463b105cbac1fa44a4fff","message":"[8.x]
[SecuritySolution][Alerts table] Fix issue with multiple ip addresses in
strings (#209475) (#209908)\n\n# Backport\n\nThis will backport the
following commits from `main` to `8.x`:\n- [[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses\nin strings
(#209475)](https://github.com/elastic/kibana/pull/209475)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Jan\nMonschke\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-02-05T20:40:17Z\",\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"Team:Threat\nHunting:Investigations\",\"backport:prev-minor\",\"backport:prev-major\",\"v9.1.0\"],\"title\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses
in\nstrings\",\"number\":209475,\"url\":\"https://github.com/elastic/kibana/pull/209475\",\"mergeCommit\":{\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/209475\",\"number\":209475,\"mergeCommit\":{\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Jan Monschke
<[email protected]>"}},{"url":"https://github.com/elastic/kibana/pull/209969","number":209969,"branch":"8.16","state":"OPEN"}]}]
BACKPORT-->
janmonschke added a commit that referenced this pull request Feb 6, 2025
…dresses in strings (#209475) (#209969)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[SecuritySolution][Alerts table] Fix issue with multiple ip addresses
in strings (#209475)](#209475)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Jan
Monschke","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-05T20:40:17Z","message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Threat
Hunting:Investigations","backport:prev-minor","backport:prev-major","v8.18.0","v9.1.0","v8.19.0"],"title":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in
strings","number":209475,"url":"https://github.com/elastic/kibana/pull/209475","mergeCommit":{"message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209909","number":209909,"state":"MERGED","mergeCommit":{"sha":"67a7a2fc842fd3e7b3a361d5b080d7a9794c01cf","message":"[9.0]
[SecuritySolution][Alerts table] Fix issue with multiple ip addresses in
strings (#209475) (#209909)\n\n# Backport\n\nThis will backport the
following commits from `main` to `9.0`:\n- [[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses\nin strings
(#209475)](https://github.com/elastic/kibana/pull/209475)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Jan\nMonschke\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-02-05T20:40:17Z\",\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"Team:Threat\nHunting:Investigations\",\"backport:prev-minor\",\"backport:prev-major\",\"v9.1.0\"],\"title\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses
in\nstrings\",\"number\":209475,\"url\":\"https://github.com/elastic/kibana/pull/209475\",\"mergeCommit\":{\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/209475\",\"number\":209475,\"mergeCommit\":{\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Jan Monschke
<[email protected]>"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209907","number":209907,"state":"MERGED","mergeCommit":{"sha":"7767ad87599a4d97027757e94abc7b9db1df3cd1","message":"[8.18]
[SecuritySolution][Alerts table] Fix issue with multiple ip addresses in
strings (#209475) (#209907)\n\n# Backport\n\nThis will backport the
following commits from `main` to `8.18`:\n- [[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses\nin strings
(#209475)](https://github.com/elastic/kibana/pull/209475)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Jan\nMonschke\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-02-05T20:40:17Z\",\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"Team:Threat\nHunting:Investigations\",\"backport:prev-minor\",\"backport:prev-major\",\"v9.1.0\"],\"title\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses
in\nstrings\",\"number\":209475,\"url\":\"https://github.com/elastic/kibana/pull/209475\",\"mergeCommit\":{\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/209475\",\"number\":209475,\"mergeCommit\":{\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Jan Monschke
<[email protected]>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209475","number":209475,"mergeCommit":{"message":"[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses in strings (#209475)\n\n##
Summary\n\nFixes
https://github.com/elastic/kibana/issues/191767\n\nMultiple IPs are now
displayed as individual links, even in the case\nwhere multiple IPs are
passed as a single string (e.g.\n`127.0.0.1,127.0.0.2`). Clicking on an
individual link will open the\nflyout correctly as
well.\n\n\n\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\n\n\n\n###
Checklist\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios\n\n---------\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"dda538111ed66cb6a36148f07a87068d7de076b6"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209908","number":209908,"state":"MERGED","mergeCommit":{"sha":"e62eef171bec5fe025f463b105cbac1fa44a4fff","message":"[8.x]
[SecuritySolution][Alerts table] Fix issue with multiple ip addresses in
strings (#209475) (#209908)\n\n# Backport\n\nThis will backport the
following commits from `main` to `8.x`:\n- [[SecuritySolution][Alerts
table] Fix issue with multiple ip addresses\nin strings
(#209475)](https://github.com/elastic/kibana/pull/209475)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Jan\nMonschke\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2025-02-05T20:40:17Z\",\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\",\"branchLabelMapping\":{\"^v9.1.0$\":\"main\",\"^v8.19.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\"Team:Threat\nHunting:Investigations\",\"backport:prev-minor\",\"backport:prev-major\",\"v9.1.0\"],\"title\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses
in\nstrings\",\"number\":209475,\"url\":\"https://github.com/elastic/kibana/pull/209475\",\"mergeCommit\":{\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.1.0\",\"branchLabelMappingKey\":\"^v9.1.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/209475\",\"number\":209475,\"mergeCommit\":{\"message\":\"[SecuritySolution][Alerts\ntable]
Fix issue with multiple ip addresses in strings
(#209475)\\n\\n##\nSummary\\n\\nFixes\nhttps://github.com//issues/191767\\n\\nMultiple
IPs are now\ndisplayed as individual links, even in the case\\nwhere
multiple IPs are\npassed as a single string
(e.g.\\n`127.0.0.1,127.0.0.2`). Clicking on an\nindividual link will
open the\\nflyout correctly
as\nwell.\\n\\n\\n\\nhttps://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558\\n\\n\\n\\n###\nChecklist\\n\\n-
[x] [Unit
or\nfunctional\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\nwere\nupdated
or added to match the most
common\nscenarios\\n\\n---------\\n\\nCo-authored-by: Elastic
Machine\n<[email protected]>\",\"sha\":\"dda538111ed66cb6a36148f07a87068d7de076b6\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Jan Monschke <[email protected]>"}}]}] BACKPORT-->
drewdaemon pushed a commit to drewdaemon/kibana that referenced this pull request Feb 6, 2025
… in strings (elastic#209475)

## Summary

Fixes elastic#191767

Multiple IPs are now displayed as individual links, even in the case
where multiple IPs are passed as a single string (e.g.
`127.0.0.1,127.0.0.2`). Clicking on an individual link will open the
flyout correctly as well.



https://github.com/user-attachments/assets/74b05cff-3843-4149-bf27-cd0af07aa558



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Elastic Machine <[email protected]>
@mistic mistic added v8.17.3 and removed v8.17.2 labels Feb 11, 2025
@mistic
Copy link
Member

mistic commented Feb 11, 2025

This PR didn't make it into the latest BC for v8.17.2. Updating the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:fix Team:Threat Hunting:Investigations Security Solution Investigations Team v8.16.4 v8.17.3 v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution]Clicking ip link in alert table throws error when ips in an array
6 participants