Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16] [Infra] Running processes missing from processes table (#209076) #209476

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

jennypavlova
Copy link
Member

Backport

This will backport the following commits from main to 8.16:

Questions ?

Please refer to the Backport tool documentation

Closes elastic#184582

## Summary

This PR fixes an issue with processes missing from the processes table
and not being searchable.

- Additional fixes: The chart size was not set correctly and they were
not visible so it is fixed now:

| Before | After |
| ---- | ------ |
|
![image](https://github.com/user-attachments/assets/3bd0788d-a89e-4cac-84af-40f6cf101613)
|
![image](https://github.com/user-attachments/assets/21ebbdc0-fcfa-4de5-a7f4-cbe855eceb7a)
|

⚠️ _UPDATE_ I also updated the archive used in the API test with the one
we have for the e2e name (and matched the name with the old one) so we
have consistent results and also the correct fields / mappings

### Solution details

After some digging into the fields I ended up **not** using the
suggested `process.name` because it gave us too generic information for
the table (we should still use the command there) also tried the process
id but then the search by command won't work properly. So I found a
field that is not ignored and contains the same information called
`process.command_line`and used it:
<img width="538" alt="image"
src="https://github.com/user-attachments/assets/ce4d35a6-e912-4656-bee1-8137d5635432"
/>

## Testing

- Follow the steps in the issue inside `How to reproduce` to create the
two processes
- Note: in order to see the process summary, you need to enable it in
the config ( ⚠️ for the oblt hosts I checked it is not enabled and the
summary section showed N/A ) :

![image](https://github.com/user-attachments/assets/ffd5fa1c-d909-4ec1-ab35-99186fc8b5e3)

https://github.com/user-attachments/assets/41bdcc8d-6b87-4351-b866-2e706dd11dfd

 - The metrics charts should be visible
 - The search should work as expected:
   - And the missing.... process should be visible

(cherry picked from commit 1f52feb)

# Conflicts:
#	x-pack/plugins/observability_solution/infra/server/lib/host_details/process_list.ts
#	x-pack/plugins/observability_solution/infra/server/lib/host_details/process_list_chart.ts
#	x-pack/test/api_integration/apis/metrics_ui/metrics_process_list.ts
#	x-pack/test/api_integration/apis/metrics_ui/metrics_process_list_chart.ts
Copy link
Contributor

github-actions bot commented Feb 4, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 4, 2025

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: edbc5c4
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-209476-edbc5c42484b

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #64 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Bootstrap Prebuilt Rules should skip installing fleet packages if they are already installed

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.7MB 1.7MB -13.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 56.5KB 56.5KB +59.0B

History

@jennypavlova jennypavlova merged commit f957712 into elastic:8.16 Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants