Skip to content

Conversation

PhilippeOberti
Copy link
Contributor

@PhilippeOberti PhilippeOberti commented Sep 26, 2025

Summary

This PR an issue that has been present for a few months: the side nav in Security Solution is rendered on top of the expandable flyout.
This issue comes from this change introduced by this PR a few months ago in EUI.

The changes suggested here are:

  • bump the document flyout's z-index from 1000 to 1001
  • bump the Timeline modal's z-index from 1001 to 1002
  • bump the timeline flyout's z-index from 1002 to 1003
  • bump all the related flyouts' z-index from 1003 to 1004

Thankfully when we had made a similar change over a year ago we had marked all the related flyouts with the following comment
// EUI TODO: This z-index override of EuiOverlayMask is a workaround, and ideally should be resolved with a cleaner UI/UX flow long-term
So it was easy to find them.

This is not an ideal fix (obviously it was already not an ideal fix over a year ago) but this will quickly get us back to a better UX, as currently if the flyout opens behind the side nav, users can't resize them at all because the handle to resize is hidden...

Before After
Screenshot 2025-09-26 at 3 08 50 PM Screenshot 2025-09-26 at 3 02 36 PM

What to test

  • make sure that the security solution flyout is always on top of the side nav

  • make sure that Timeline is always on top of the security solution flyout

  • make sure that the timeline flyout is always on top of Timeline

  • make sure that the flyout on the ESQL tab in Timeline behaves correctly

  • make sure these work after a page refresh

  • make sure that things work both with overlay and push modes

  • make sure that all secondary flyouts - accessible via the Take action button in the flyout's footer - are displayed on top.

    • Add to new case
    • Isolate host
    • Respond
    • Add endpoint exception
    • Add rule exception
    • ...
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

  • Review the backport guidelines and apply applicable backport:* labels.

@PhilippeOberti PhilippeOberti added release_note:fix backport:skip This PR does not require backporting Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v9.2.0 labels Sep 26, 2025
@PhilippeOberti PhilippeOberti force-pushed the fix-expandable-flyout-zindex branch from 786c9d1 to cf33fdd Compare September 26, 2025 20:24
…nents' z-index by 1 to be on top of side nav
@PhilippeOberti PhilippeOberti force-pushed the fix-expandable-flyout-zindex branch from cf33fdd to 2f0bed4 Compare September 26, 2025 21:53
@PhilippeOberti PhilippeOberti marked this pull request as ready for review September 27, 2025 00:11
@PhilippeOberti PhilippeOberti requested review from a team as code owners September 27, 2025 00:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-only review, Data Discovery changes LGTM

Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection Engine changes LGTM. I had one question about an added prop that wasn't there before, and one suggestion for future improvements here 👍

Copy link
Contributor

@lgestc lgestc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cases here, looking good. desk tested, new case flyout rendered correctly.

Copy link
Contributor

@NicholasPeretti NicholasPeretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for this! ☺️

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 1.4MB 1.4MB +45.0B
securitySolution 11.1MB 11.1MB +175.0B
total +220.0B

History

@PhilippeOberti PhilippeOberti merged commit 7e0948d into elastic:main Oct 1, 2025
12 checks passed
@PhilippeOberti PhilippeOberti deleted the fix-expandable-flyout-zindex branch October 1, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This PR does not require backporting release_note:fix Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants