[Search] Remove unused kbn-search-api-panels code #236713
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seialkali
changed the title
seialkali
force-pushed
the
remove-unused-kbn-search-api-panels
branch
from
943b88a to
f252ae0
Compare
seialkali
added
release_note:skip
| } | ||
| ); | ||
| export const API_KEY_PLACEHOLDER = 'your_api_key'; | ||
| export const ELASTICSEARCH_URL_PLACEHOLDER = 'https://your_deployment_url'; |
There was a problem hiding this comment.
ELASTICSEARCH_URL_PLACEHOLDER only refers from cloud_details which is also getting removed. May be we can remove this whole?
| import type { AuthenticatedUser } from '@kbn/security-plugin/common'; | ||
|
|
||
| export * from './components/cloud_details'; | ||
| export * from './components/code_box'; |
There was a problem hiding this comment.
Curious why are we keeping code_box, ingest_pipeline_panel, and github_link? It looks like all references to them are being removed from the plugin. Unless they are used outside the plugin or somewhere else, maybe we can remove those too?
There was a problem hiding this comment.
They are still used in index management if I recall correctly.
| "node", | ||
| "react" | ||
| ] | ||
| "types": ["jest", "node", "react"] |
There was a problem hiding this comment.
You probably need to disable linting for .json files to avoid reformatting existing files in the Kibana.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes unused code within the
kbn-search-api-panelspackage.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support`Documentation was added for features that require explanation or tutorialsIf a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. Therelease_note:breakinglabel should be applied in these situations.The PR description includes the appropriate Release Notes section, and the correctrelease_note:*label is applied per the guidelinesReview the backport guidelines and apply applicablebackport:*labels.