[9.1] [Lens][Table] Fix csv export column sort order (#236673) #237010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary When a table from a dashboard using the **Download CSV** action, the column sort order visible in the table on the dashboard are preserved in the csv output. https://github.com/user-attachments/assets/7454a511-150b-45a2-86c5-1cd61bc0191a Fixes elastic#236550 ## Details The `datatable_fn` is used to set the table of data to the `adapters`, which is the data used in the csv export action. This data comes in out of order with additional `Part of X` columns for formula columns. However, we do not sort these in before passing to the adapters. Normally, with formulas, this is not a problem as the columns are in the correct order but the [`tabify`](https://github.com/elastic/kibana/blob/8d4b0956586284c35db97de2baea49b58476ee2a/src/platform/plugins/shared/data/common/search/tabify/tabify.ts#L24) logic mixes up the column order for formulas. The fix is to simply sort the columns in the table before passing it to the `adapters.` ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ## Release Note Fixes a bug in the Lens table in which exporting the table from a dashboard, which containg formula columns, can result in a different column order than shown on the dashboard. Co-authored-by: Marco Liberati <[email protected]> (cherry picked from commit ef105c5)
3 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @nickofthyme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:Questions ?
Please refer to the Backport tool documentation