[One Discover] Fix filter actions not closing cell popups #241749
+37
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #215293
Summary
Discover
This PR introduces updates on how we handle cell popover visibility after applying filtering quick actions (filter in/out) for the
UnifiedDataTablein Discover.Up until now, applying filter actions wouldn't close expanded cell popovers. For filter in actions, this provides an inconsistent UX as the popover would sometimes remain open while other times it would close after the filter is applied
Filter.In.-.No.Fix.mov
For filter out actions, the situation is even worse as the popover will remain open even though the cell it belongs to is no longer in view (as we just filtered it out!)
Filter.Out.-.No.Fix.mov
Contextual Components
This fix must also pay special attention to the observability solution view. In this mode, the summary column is enhanced with, among other things, resource badge components that allow applying filtering actions scoped to the specific resource. When applying these filters the issue is much like before where no cell popovers are closed after applying filtering actions
Contextual.Component.-.No.Fix.mov
Fixes
Discover
After the fix in this PR, this is how the UX for regular discover works. Notice how the popover is closed right after pressing the quick action button, in both filter in and out cases and without inconsistent behaviour.
Discover.-.Fix.mov
Contextual Components
For contextual components too, notice how both the badge popover and the cell popover itself are closed after applying the quick action
Contextual.Component.-.Fix.mov