Skip to content

Conversation

@andsel
Copy link
Contributor

@andsel andsel commented Aug 1, 2025

Release notes

What does this PR do?

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • move all metric_store_spec.rb to cover the Java MetricStore
  • move the Collector and collector_spec.rb

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2025

This pull request does not have a backport label. Could you fix it @andsel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@andsel andsel mentioned this pull request Aug 1, 2025
2 tasks
@andsel andsel changed the title Feature/reimplement metric store in pure java [WIP on-hold]Feature/reimplement metric store in pure java Aug 1, 2025
@andsel andsel changed the title [WIP on-hold]Feature/reimplement metric store in pure java [WIP on-hold] Reimplement metric store in pure java Aug 1, 2025
…Ruby implementation is just a wrapper that uses and exposes the Java implementation
@andsel andsel force-pushed the feature/reimplement_metric_store_in_pure_java branch from 6beaf90 to 3a9327e Compare December 30, 2025 10:41
andsel added 5 commits January 9, 2026 16:21
…Store (which contains just plain strings as keys) generates this problem, of flattening everything to string and later string to sym when it returns the result map
…batch.event_count and pipelines.main.batch.byte_size metric subdocuments doesn't exists while processing the response that make fail, the whole reponse creationg returning an empty dictionary for pipelines at Node command: https://github.com/elastic/logstash/blob/f9d8b771e565bfe35fc71e72ae389eaa3df26d03/logstash-core/lib/logstash/api/commands/node.rb#L43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants