Skip to content

1 #18391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tangmingli666 wants to merge 1 commit into from
+7 −1
Closed

1 #18391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion logstash-core/src/main/java/org/logstash/ackedqueue/Queue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,16 +753,22 @@ public void ack(final long firstAckSeqNum, final int ackCount) throws IOExceptio
// as a first implementation we assume that all batches are created from the same page
lock.lock();
try {
boolean wasFull = isFull();

if (containsSeq(headPage, firstAckSeqNum)) {
this.headPage.ack(firstAckSeqNum, ackCount, this.checkpointMaxAcks);
} else {
final int resultIndex = binaryFindPageForSeqnum(firstAckSeqNum);
if (tailPages.get(resultIndex).ack(firstAckSeqNum, ackCount, this.checkpointMaxAcks)) {
this.tailPages.remove(resultIndex);
notFull.signalAll();
}
this.headPage.checkpoint();
}

// If we were full before the ack and are not full anymore, signal that we might not be full
if (wasFull && !isFull()) {
notFull.signalAll();
}
} finally {
lock.unlock();
}
Expand Down