Skip to content

Use basic/token auth when doing explicitly constructed requests #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisberkhout wants to merge 2 commits into from
Closed

Use basic/token auth when doing explicitly constructed requests #110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e64a44c
Use basic/token auth whenever configured, including for manually cons…
chrisberkhout Aug 22, 2025
2920b2f
Tweak doc.
chrisberkhout Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,9 @@ import (
// will be used for the requests and API rate limiting. If client is nil
// the http.DefaultClient will be used and if limit is nil an non-limiting
// rate.Limiter will be used. If auth is not nil, the Authorization header
// is populated for Basic Authentication or token authentication in requests
// constructed for direct HEAD, GET and POST method calls. Explicitly constructed
// requests used in do_request are not affected by auth. In cases where Basic
// Authentication is needed for these constructed requests, the
// basic_authentication method can be used to add the necessary header.
// is populated for basic authentication or token authentication. Explicitly
// constructed requests can alternatively add basic authentication in CEL,
// using the basic_authentication method.
//
// # HEAD
//
Expand Down Expand Up @@ -846,6 +844,12 @@ func (l httpLib) doRequest(arg ref.Val) ref.Val {
if err != nil {
return types.NewErr("%s", err)
}
if l.options.BasicAuth != nil {
req.SetBasicAuth(l.options.BasicAuth.Username, l.options.BasicAuth.Password)
}
if l.options.TokenAuth != nil {
l.options.TokenAuth.AddTo(req.Header)
}
addHeaders(req, l.options.Headers)
resp, err := l.client.Do(req)
if err != nil {
Expand Down
Loading