Skip to content

fix: resolve encode_json error for ref.Val lists #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewkroh merged 1 commit into from
Sep 16, 2025
Merged

fix: resolve encode_json error for ref.Val lists #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/json.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ func encodeJSON(val ref.Val) ref.Val {
switch under := val.Value().(type) {
case map[string]any:
v = under
case map[ref.Val]ref.Val:
case map[ref.Val]ref.Val, []ref.Val:
pb, err := val.ConvertToNative(structpbValueType)
if err != nil {
return types.NewErr("failed proto conversion: %v", err)
Expand Down
4 changes: 3 additions & 1 deletion testdata/json_encode.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ cmp stdout want.txt
}),
"plain text".encode_json(),
encode_json("plain text"),
[0, 1].map(i, {"a":i}).encode_json()
]
-- want.txt --
[
Expand All @@ -32,5 +33,6 @@ cmp stdout want.txt
"{\"a\":{\"b\":{\"c\":1}}}",
"{\"a\":{\"b\":{\"c\":1}}}",
"\"plain text\"",
"\"plain text\""
"\"plain text\"",
"[{\"a\":0},{\"a\":1}]"
]
Loading