Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Oct 23, 2025

Closes #370

@v1v v1v self-assigned this Oct 23, 2025
@v1v v1v requested a review from a team as a code owner October 23, 2025 15:49
@v1v v1v added the changelog:ci When you add a change that is related to CI label Oct 23, 2025
Copilot AI review requested due to automatic review settings October 23, 2025 15:49
@v1v v1v enabled auto-merge October 23, 2025 15:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes CI workflows by removing expensive end-to-end tests while maintaining signature validation. The changes reduce unnecessary infrastructure creation and teardown operations that were running as part of the test suite, particularly targeting tests that actually create clusters with wait periods.

Key changes:

  • Removed expensive "wait" jobs that create real infrastructure
  • Added conditional execution to skip undeploy operations during merge group events
  • Standardized dry-run input handling across workflows

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/test-oblt-cli-undeploy-my-kibana.yml Added dry-run input parameter and conditional execution to skip during merge groups
.github/workflows/test-oblt-cli-cluster-create-serverless.yml Removed expensive "wait" job that creates and destroys real clusters
.github/workflows/test-oblt-cli-cluster-create-custom.yml Removed "wait" job and standardized dry-run parameter handling
.github/workflows/test-oblt-cli-cluster-create-ccs.yml Removed expensive "wait" job that creates infrastructure with wait periods

dry-run:
description: 'Dry run'
required: true
default: false
Copy link

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value for dry-run is set to false, but line 35 adds a condition to skip execution during merge_group events. This creates inconsistent behavior: workflow_dispatch will execute real undeploy operations by default (potentially dangerous), while merge_group skips execution entirely. The default should be true to ensure safe behavior unless explicitly overridden.

Suggested change
default: false
default: true

Copilot uses AI. Check for mistakes.
workflow_dispatch: ~
workflow_dispatch:
inputs:
dry-run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm not wrong, this parameter is not used in this workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci When you add a change that is related to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit the implementation for the e2e in oblt-cli and use --dry-run instead

3 participants