- 
                Notifications
    You must be signed in to change notification settings 
- Fork 9
ci: avoid running expensive e2e but validate signature #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR optimizes CI workflows by removing expensive end-to-end tests while maintaining signature validation. The changes reduce unnecessary infrastructure creation and teardown operations that were running as part of the test suite, particularly targeting tests that actually create clusters with wait periods.
Key changes:
- Removed expensive "wait" jobs that create real infrastructure
- Added conditional execution to skip undeploy operations during merge group events
- Standardized dry-run input handling across workflows
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description | 
|---|---|
| .github/workflows/test-oblt-cli-undeploy-my-kibana.yml | Added dry-run input parameter and conditional execution to skip during merge groups | 
| .github/workflows/test-oblt-cli-cluster-create-serverless.yml | Removed expensive "wait" job that creates and destroys real clusters | 
| .github/workflows/test-oblt-cli-cluster-create-custom.yml | Removed "wait" job and standardized dry-run parameter handling | 
| .github/workflows/test-oblt-cli-cluster-create-ccs.yml | Removed expensive "wait" job that creates infrastructure with wait periods | 
| dry-run: | ||
| description: 'Dry run' | ||
| required: true | ||
| default: false | 
    
      
    
      Copilot
AI
    
    
    
      Oct 23, 2025 
    
  
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value for dry-run is set to false, but line 35 adds a condition to skip execution during merge_group events. This creates inconsistent behavior: workflow_dispatch will execute real undeploy operations by default (potentially dangerous), while merge_group skips execution entirely. The default should be true to ensure safe behavior unless explicitly overridden.
| default: false | |
| default: true | 
| workflow_dispatch: ~ | ||
| workflow_dispatch: | ||
| inputs: | ||
| dry-run: | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not wrong, this parameter is not used in this workflow
Closes #370