Fix for Variable defined multiple times #397
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR removes a redundant variable assignment that was causing labels_json to be defined multiple times in the backport script. The removed line was attempting to access the PR_LABELS environment variable without a fallback, while a safer assignment with a default value exists elsewhere in the code.
Key Changes
- Removed the unsafe assignment of
labels_jsonfrom the environment variables (line 11) - The safer assignment with default handling (presumably on line 22, though not visible in this diff) remains intact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the problem, simply remove the redundant assignment to
labels_jsonon line 11. The second assignment on line 22 correctly initializeslabels_jsonwith a default value if the environment variable is missing, which is safer than the assignment on line 11 (which could raise a KeyError). No other changes are needed. The change should only be in the region wherelabels_jsonis assigned for the first time (line 11), and the rest of the logic remains unchanged.Suggested fixes powered by Copilot Autofix. Review carefully before merging.