Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Link to ECS fields reference from integration page and adjust developer guide #3968

Closed
1 of 2 tasks
flash1293 opened this issue Jun 5, 2024 · 9 comments
Closed
1 of 2 tasks

Comments

@flash1293
Copy link
Contributor

flash1293 commented Jun 5, 2024

Description

The ecs@mappings component template is now applied automatically for all data streams, correctly configuring ECS fields in the mapping by default. This means that ECS fields don't need to be specified as part of an integration. This is causing two changes:

Resources

This doc is describing the change: https://docs.google.com/document/d/1I5GKUB8AWUdEhqNjhHE2CXDeUMHk3_kcMaI3xKbQ16g/edit

Which documentation set does this change impact?

Stateful and Serverless

Feature differences

No difference

What release is this request related to?

N/A

Collaboration model

The documentation team

Point of contact.

Main contact: @flash1293

Stakeholders: @ishleenk17 @zmoog

@alaudazzi
Copy link
Contributor

alaudazzi commented Jun 6, 2024

@flash1293

On this page https://www.elastic.co/guide/en/integrations-developer/current/add-a-mapping.html#_agent_yml , it's not necessary anymore to specify ecs fields, as they are defined by default via the standard index template

I will open a PR to fix this page

On integration pages (like https://docs.elastic.co/integrations/nginx ), this will cause the ecs fields to not be listed anymore - instead we should introduce a prominent link to the central ECS field specifications

The Exported fields table is generated.
@zmoog @ishleenk17 do you know which source file should be updated to address the change that Joe is requesting?

@flash1293
Copy link
Contributor Author

flash1293 commented Jun 6, 2024

@alaudazzi the generated table is coming from the integration itself - the idea was to still render that one, but also provide a link to the central ECS reference.

Right now, the exported fields list contains some ECS fields by default, once we have the central link, we can remove the ECS fields from the table on that page by updating the integrations itself one-by-one (this is what @ishleenk17 is currently working on)

@alaudazzi
Copy link
Contributor

@flash1293

@ishleenk17 and I have just met and agreed on the following steps. Please review and comment:

  1. The integrations team will remove the ecs fields from the Exported fields generated table on each integration page
  2. On all the integrations doc pages, we could reference the ECS fields definitions by adding a link to this page https://www.elastic.co/guide/en/ecs/current/ecs-field-reference.html
  3. Arianna will update the https://www.elastic.co/guide/en/integrations-developer/current/add-a-mapping.html#_agent_yml page by removing the ecs.yml section.

@flash1293
Copy link
Contributor Author

@alaudazzi That matches my understanding

@ishleenk17
Copy link

2. On all the integrations doc pages, we could reference the ECS fields definitions by adding a link to this page https://www.elastic.co/guide/en/ecs/current/ecs-field-reference.html

@flash1293 : This is the link that I found for ECS references. I am hoping this is always the latest one. So each Integration will provide a link to this for ECS definitions.

3. Arianna will update the https://www.elastic.co/guide/en/integrations-developer/current/add-a-mapping.html#_agent_yml page by removing the ecs.yml section.

@alaudazzi @flash1293 : I think changes might be needed to the agent.yml and base-fields.yml section as well. As we discussed to remove the ecs fields from these files as well.

@alaudazzi
Copy link
Contributor

@ishleenk17 @flash1293
I pushed a PR to remove the ecs.yml section. Please confirm if the agent.yml and base-fields.yml sections need to be removed as well.

@alaudazzi
Copy link
Contributor

@flash1293
This ticket contains tasks that could be split into separate issues. I can create them and close this one if it's OK with you.

@flash1293
Copy link
Contributor Author

@alaudazzi sounds good to me 👍

@alaudazzi
Copy link
Contributor

Closing this ticket and breaking down into the following issues:

  1. The integrations team will remove the ecs fields from the Exported fields generated table on each integration page
    https://github.com/elastic/integration-docs/issues/450
  2. On all the integrations doc pages, we could reference the ECS fields definitions by adding a link to this page https://www.elastic.co/guide/en/ecs/current/ecs-field-reference.html
    [Request]: Reference the ECS fields from the integrations doc pages #4029
  3. Arianna will update the https://www.elastic.co/guide/en/integrations-developer/current/add-a-mapping.html#_agent_yml page by removing the ecs.yml section.
    Remove the ecs.yml section #3989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants