Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ecs.yml section #3989

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Remove the ecs.yml section #3989

merged 1 commit into from
Jun 17, 2024

Conversation

alaudazzi
Copy link
Contributor

As ECS fields no longer need to be specified as part of an integration, this PR removes the ecs.yml section as requested in #3968.

@alaudazzi alaudazzi added the docs Improvements or additions to documentation label Jun 11, 2024
@alaudazzi alaudazzi self-assigned this Jun 11, 2024
@alaudazzi alaudazzi marked this pull request as ready for review June 11, 2024 09:10
@alaudazzi alaudazzi requested a review from a team as a code owner June 11, 2024 09:10
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Jun 11, 2024

This pull request does not have a backport label. Could you fix it @alaudazzi? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jun 11, 2024
@flash1293
Copy link
Contributor

@ishleenk17 should there be changes to base.yml and agent.yml as well? I know we sometimes define values for constant keywords, those should stay, but maybe we can omit something else?

@alaudazzi alaudazzi added backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jun 11, 2024
@ishleenk17
Copy link

@ishleenk17 should there be changes to base.yml and agent.yml as well? I know we sometimes define values for constant keywords, those should stay, but maybe we can omit something else?

Yes, the plan is to remove the ecs fields from these files. But, need to see how we can specify that in the documentation

@alaudazzi
Copy link
Contributor Author

@ishleenk17

Yes, the plan is to remove the ecs fields from these files. But, need to see how we can specify that in the documentation

Is there any additional update expected on this page https://www.elastic.co/guide/en/integrations-developer/current/add-a-mapping.html#_agent_yml? Otherwise, we can handle further doc updates in separate PRs.

@alaudazzi
Copy link
Contributor Author

@ishleenk17
A gentle reminder on this point.

@ishleenk17
Copy link

@ishleenk17 A gentle reminder on this point.

Lets handle the agent.yml and base-fields.yml in future PR's.
we are good to go on this one.

@bmorelli25 bmorelli25 merged commit 14a9613 into main Jun 17, 2024
19 checks passed
@bmorelli25 bmorelli25 deleted the alaudazzi-patch-1 branch June 17, 2024 13:21
mergify bot pushed a commit that referenced this pull request Jun 17, 2024
(cherry picked from commit 14a9613)
mergify bot pushed a commit that referenced this pull request Jun 17, 2024
(cherry picked from commit 14a9613)
bmorelli25 pushed a commit that referenced this pull request Jun 17, 2024
(cherry picked from commit 14a9613)

Co-authored-by: Arianna Laudazzi <[email protected]>
bmorelli25 pushed a commit that referenced this pull request Jun 17, 2024
(cherry picked from commit 14a9613)

Co-authored-by: Arianna Laudazzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants