-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[synthetics] Add fields
synthetics configuration option
#4319
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
right now they can't but i am not sure if we need to support fields via cli cc @vigneshshanmugam @emilioalvap ? |
@colleenmcginnis About CLI options, @shahzad31's PR should add support for that: elastic/synthetics#963 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
we can also add that we support in CLI as well via --fields param, either you can wait for PR to merge or just do it right now, because it will be merged soon !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚢 it!!
24437e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦕
* add fields to configuration docs * address feedback from @shahzad31 * add cli option (cherry picked from commit b7f1f8a)
) * add fields to configuration docs * address feedback from @shahzad31 * add cli option (cherry picked from commit b7f1f8a) Co-authored-by: Colleen McGinnis <[email protected]>
Description
Add
fields
configuration option for synthetic monitoring.Documentation sets edited in this PR
Check all that apply.
docs/en/observability/*
)docs/en/serverless/*
)docs/en/integrations/*
)Related issue
Closes #4274
Checklist
Follow-up tasks
Select one.