Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[synthetics] Add fields synthetics configuration option #4319

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Sep 30, 2024

Description

Add fields configuration option for synthetic monitoring.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4274

Checklist

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:

@colleenmcginnis colleenmcginnis added needs-writer-review backport-8.x Automated backport to the 8.x branch with mergify needs-dev-review labels Sep 30, 2024
@colleenmcginnis colleenmcginnis self-assigned this Sep 30, 2024
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner September 30, 2024 20:24
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@shahzad31
Copy link
Contributor

shahzad31 commented Oct 1, 2024

 CLI option?
@shahzad31 can users also add fields via the CLI?

right now they can't but i am not sure if we need to support fields via cli cc @vigneshshanmugam @emilioalvap ?

@emilioalvap
Copy link
Contributor

@colleenmcginnis About CLI options, @shahzad31's PR should add support for that: elastic/synthetics#963

shahzad31
shahzad31 previously approved these changes Oct 2, 2024
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

we can also add that we support in CLI as well via --fields param, either you can wait for PR to merge or just do it right now, because it will be merged soon !!

bmorelli25
bmorelli25 previously approved these changes Oct 2, 2024
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢 it!!

@colleenmcginnis colleenmcginnis dismissed stale reviews from bmorelli25 and shahzad31 via 24437e2 October 2, 2024 19:00
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦕

@colleenmcginnis colleenmcginnis mentioned this pull request Oct 2, 2024
6 tasks
@colleenmcginnis colleenmcginnis merged commit b7f1f8a into elastic:main Oct 2, 2024
3 checks passed
@colleenmcginnis colleenmcginnis deleted the issue-4274 branch October 2, 2024 20:47
mergify bot pushed a commit that referenced this pull request Oct 2, 2024
* add fields to configuration docs

* address feedback from @shahzad31

* add cli option

(cherry picked from commit b7f1f8a)
colleenmcginnis added a commit that referenced this pull request Oct 2, 2024
)

* add fields to configuration docs

* address feedback from @shahzad31

* add cli option

(cherry picked from commit b7f1f8a)

Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify needs-dev-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Document labels for Synthetics monitors
5 participants