Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document no data settings for custom threshold rule #4418

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Oct 22, 2024

Description

Adds documentation that explain new setting "no data" setting for the custom threshold rule.

Link to preview: https://observability-docs_bk_4418.docs-preview.app.elstc.co/guide/en/observability/master/custom-threshold-alert.html#trigger-alert-when-no-data

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4068

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: ADD ISSUE LINK BEFORE MERGING

@dedemorton dedemorton self-assigned this Oct 22, 2024
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Oct 22, 2024

This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 22, 2024
@dedemorton dedemorton added backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify needs-dev-review and removed backport-skip Skip notification from the automated backport with mergify labels Oct 22, 2024
@dedemorton dedemorton changed the title [WIP] Document no data settings for custom threshold rule Document no data settings for custom threshold rule Oct 22, 2024
@dedemorton dedemorton marked this pull request as ready for review October 22, 2024 18:42
@dedemorton dedemorton requested a review from a team as a code owner October 22, 2024 18:42
@bmorelli25
Copy link
Member

run docs-build

Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's amazing! Thanks! 💖

Does it make sense also to mention that "no data" has its own action group? Is this already covered somewhere?

@dedemorton
Copy link
Contributor Author

Does it make sense also to mention that "no data" has its own action group? Is this already covered somewhere?

That's covered where actions are described, so I don't think I would mention it here.

Copy link
Contributor

@eedugon eedugon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me ;)

@dedemorton dedemorton merged commit ec217ce into elastic:main Oct 24, 2024
17 checks passed
@dedemorton dedemorton deleted the issue#4068 branch October 24, 2024 18:08
mergify bot pushed a commit that referenced this pull request Oct 24, 2024
mergify bot pushed a commit that referenced this pull request Oct 24, 2024
dedemorton added a commit that referenced this pull request Oct 24, 2024
dedemorton added a commit that referenced this pull request Oct 24, 2024
dedemorton added a commit to dedemorton/observability-docs that referenced this pull request Oct 28, 2024
dedemorton added a commit that referenced this pull request Oct 29, 2024
eedugon pushed a commit to eedugon/observability-docs that referenced this pull request Nov 6, 2024
eedugon pushed a commit to eedugon/observability-docs that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify needs-dev-review needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Documenting no-data settings for the custom threshold rule
4 participants