Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15](backport #4444) add synthetics multi factor authentication docs #4474

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 4, 2024

Description

Add docs around the TOTP based MFA support in Synthetics elastic/synthetics#957 and elastic/synthetics#975

Documentation sets edited in this PR

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4334

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

This is an automatic backport of pull request #4444 done by [Mergify](https://mergify.com).

* add synthetics multi factor authentication docs

* apply suggestions from code review

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>

* Apply suggestions from code review

Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>

* Update docs/en/observability/synthetics-mfa.asciidoc

Co-authored-by: Colleen McGinnis <[email protected]>

---------

Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
Co-authored-by: Brandon Morelli <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
(cherry picked from commit 704f88d)

# Conflicts:
#	docs/en/observability/index.asciidoc
#	docs/en/serverless/serverless-observability.docnav.json
#	docs/en/serverless/synthetics/synthetics-command-reference.mdx
@mergify mergify bot requested a review from a team as a code owner November 4, 2024 19:08
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Nov 4, 2024
Copy link
Contributor Author

mergify bot commented Nov 4, 2024

Cherry-pick of 704f88d has failed:

On branch mergify/bp/8.15/pr-4444
Your branch is up to date with 'origin/8.15'.

You are currently cherry-picking commit 704f88d6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/en/observability/synthetics-command-reference.asciidoc
	new file:   docs/en/observability/synthetics-mfa.asciidoc
	new file:   docs/en/serverless/synthetics/synthetics-mfa.mdx

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   docs/en/observability/index.asciidoc
	deleted by us:   docs/en/serverless/serverless-observability.docnav.json
	deleted by us:   docs/en/serverless/synthetics/synthetics-command-reference.mdx

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

github-actions bot commented Nov 4, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@bmorelli25
Copy link
Member

This backport will require some finagling. We made updates to the IA of the Observability Guide in 8.16

@bmorelli25 bmorelli25 merged commit f0be900 into 8.15 Nov 4, 2024
4 checks passed
@bmorelli25 bmorelli25 deleted the mergify/bp/8.15/pr-4444 branch November 4, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants