Skip to content

fix(test): stop reusing the reserved "percentage" axis-label alias as incidental sample data #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shmsr merged 1 commit into from
Aug 19, 2026
+8 −2
Merged

fix(test): stop reusing the reserved "percentage" axis-label alias as incidental sample data #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/test_migrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13138,11 +13138,17 @@ def test_extract_xy_appearance_hides_time_axis_title_from_override(self):

def test_extract_xy_appearance_omits_line_area_style_for_bar(self):
from observability_migration.targets.kibana.emit.display import extract_xy_appearance
# NOTE: "percentage" is deliberately NOT used here -- it is a reserved
# opaque Grafana-unit-id alias (see _OPAQUE_AXIS_TITLE_ALIASES /
# test_extract_axis_label_suppresses_grafana_unit_id_aliases) whose
# title is intentionally suppressed. This test's own purpose is
# unrelated: it only checks that bar charts keep axis config while
# dropping line/area-only appearance keys, so use ordinary label text.
panel = {
"fieldConfig": {
"defaults": {
"custom": {
"axisLabel": "percentage",
"axisLabel": "CPU usage",
"drawStyle": "bars",
"lineInterpolation": "smooth",
"fillOpacity": 70,
Expand All @@ -13151,7 +13157,7 @@ def test_extract_xy_appearance_omits_line_area_style_for_bar(self):
}
}
appearance = extract_xy_appearance(panel, chart_type="bar")
self.assertEqual(appearance["y_left_axis"]["title"], "percentage")
self.assertEqual(appearance["y_left_axis"]["title"], "CPU usage")
self.assertNotIn("line_style", appearance)
self.assertNotIn("fill_opacity", appearance)
area_appearance = extract_xy_appearance(panel, chart_type="area")
Expand Down
Loading