feat(grafana): MySQL 7362 and PostgreSQL 9628/14114 curated packs - #369
Open
shmsr wants to merge 2 commits into
Open
feat(grafana): MySQL 7362 and PostgreSQL 9628/14114 curated packs#369shmsr wants to merge 2 commits into
shmsr wants to merge 2 commits into
Conversation
Operators migrating these community dashboards hit exporter typing, Helm label noise, and metric-name drift that a generic PromQL pass cannot know. Bundle packs plus the engine support they need so the installable CLI produces usable Kibana panels without a custom rules file.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| return None | ||
| if "computed_value" in metric_fields: | ||
| metric_col = "computed_value" | ||
| metric_fields = ["computed_value"] |
| return None | ||
| if "computed_value" in metric_fields: | ||
| metric_col = "computed_value" | ||
| metric_fields = ["computed_value"] |
Bare instant gauges were kept native before the live-missing check, so absent tiles scored green and Elasticsearch could emit value_$1/$2 instead of value. Fall through to telemetry-missing markdown, treat CONCAT EVAL aliases as series keys, and expect ignored-label matchers to stay native after stripping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--rules-file.ignored_labelsfrom native PromQL (and skip synthesizing those controls), do not yellow panels whose source metric islive_optionaland absent, Grafana 5 singlestat units/decimals, and treat surviving EVAL aliases as Lens series.mysql-load/postgres-loadplus mysqld_exporter counter typing in the redis curated compose so 7362/9628 are not idle zero scrapes.Test plan
pytest tests/test_curated_packs.py tests/test_migrate.py tests/targets/kibana/test_esql_utils.pymetrics-*(--translation-mode auto --upload --smoke)pg_up, notup)grafana-validate-uploadedon the three dashboards: no empty/error panels that are not documented pack approximations (9628 Version / Start Time remain approximate by design)