Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table_name_prefix error on Rails 7.1.3 #43

Merged

Conversation

tnantoka
Copy link
Contributor

Thank you for the excellent gem! I've been using this for several years and it works great.

I recently updated my app to Rails 7.1.3 and a strange error occurred. I think you can easily reproduce it by following the steps below.

$ bundle update --gemfile /app/gemfiles/rails7.gemfile
...
Using activerecord 7.1.3 (was 7.1.1)
...

$ bundle exec appraisal rspec
...
      ActiveRecord::StatementInvalid:
        Could not find table 'lets_encrypt_certificates'
...
32 examples, 24 failures

It seems that table_name_prefix is not working properly. This may be a Rails issue, but I found that using table_name instead would solve the problem. So I created a pull request.

If you don't need this, please feel free to close it.

Thanks,

@elct9620
Copy link
Owner

It seems the selected Nokogiri version does not support Ruby 2.7 🤔

@tnantoka
Copy link
Contributor Author

@elct9620
Sorry, I've reverted some unnecessary changes.

@elct9620
Copy link
Owner

elct9620 commented Feb 13, 2024

@tnantoka I think you need to make a signing commit to pass the GitHub check.

auto-merge was automatically disabled February 13, 2024 13:45

Head branch was pushed to by a user without write access

@tnantoka tnantoka force-pushed the bugfix/table-name-prefix-on-rails-7.1.3 branch from 7ee7e15 to ce39472 Compare February 13, 2024 13:45
@tnantoka
Copy link
Contributor Author

@elct9620
Thank you for reviewing. I've signed my commits and pushed again.

@elct9620 elct9620 merged commit fe719e1 into elct9620:main Feb 13, 2024
9 checks passed
@elct9620
Copy link
Owner

v0.11.3 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants