Skip to content

Conversation

Copy link

Copilot AI commented Jan 7, 2026

Updated .github/instructions/testing_feature_area.instructions.md to reflect the named pipe refactoring from PR #24 which simplified the API and improved resource management.

Changes

  • Added "Named pipe lifecycle management" section documenting:

    • startDiscoveryNamedPipe and startRunResultNamedPipe now return Promise<string> (pipe name only) instead of { name: string } & Disposable
    • Automatic cleanup via cancellation tokens—no manual dispose() calls needed
    • FIFO permissions now set to 0o666 on Linux/Mac
    • Pytest-specific Python function renames: execution_post()send_execution_message(), post_response()send_discovery_message(), send_post_request()send_message()
  • Updated "History & evolution" with PR Fixes to fifo #24 entry

  • Updated "Pointers for contributors" to clarify cancellation-token-based cleanup pattern

Pattern Change

Before:

const { name, dispose } = await startDiscoveryNamedPipe(callback);
// ... later
dispose();

After:

const cSource = new CancellationTokenSource();
const name = await startDiscoveryNamedPipe(callback, cSource.token);
// ... later
cSource.cancel(); // automatic cleanup
Original prompt

update the documentation for this repo to reflect recent PRs

Created from VS Code.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Update documentation to reflect recent pull requests Document named pipe lifecycle changes from PR #24 Jan 7, 2026
Copilot AI requested a review from eleanorjboyd January 7, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants