Improve isInsertUpdateOrDeleteStatement and docstring for getRowsModi…

…fied.
electric-sql · Nov 27, 2023 · 054db7a · 054db7a
1 parent dc6bde9
commit 054db7a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/clients/typescript/src/drivers/generic/adapter.ts b/clients/typescript/src/drivers/generic/adapter.ts
@@ -33,7 +33,7 @@ abstract class DatabaseAdapter
   abstract exec(statement: Statement): Promise<Row[]>
 
   /**
-   * @returns The number of rows modified by the last SQL query.
+   * @returns The number of rows modified by the last insert/update/delete query.
    */
   abstract getRowsModified(): number
 

diff --git a/clients/typescript/src/util/statements.ts b/clients/typescript/src/util/statements.ts
@@ -1,12 +1,7 @@
 import { SqlValue, Statement } from './types'
 
-export function isInsertUpdateOrDeleteStatement(sql: string) {
-  const tpe = sql.toLowerCase().trimStart()
-  return (
-    tpe.startsWith('insert') ||
-    tpe.startsWith('update') ||
-    tpe.startsWith('delete')
-  )
+export function isInsertUpdateOrDeleteStatement(stmt: string) {
+  return /^\s*(insert|update|delete)/i.test(stmt)
 }
 
 /**