Skip to content

Commit

Permalink
Remove DataValidationErrors that are already raised at higher levels
Browse files Browse the repository at this point in the history
  • Loading branch information
robacourt committed Jul 1, 2024
1 parent f19a671 commit 6545a4e
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions components/electric/lib/electric/satellite/serialization.ex
Original file line number Diff line number Diff line change
Expand Up @@ -746,29 +746,14 @@ defmodule Electric.Satellite.Serialization do

defp assert_valid_month!(month) when month in 1..12, do: :ok

defp assert_valid_month!(month),
do: raise(DataValidationError, message: "Month out of range: #{month}")

defp assert_valid_day!(day) when day in 1..31, do: :ok

defp assert_valid_day!(day),
do: raise(DataValidationError, message: "Day out of range: #{day}")

defp assert_valid_hours!(hours) when hours in 0..23, do: :ok

defp assert_valid_hours!(hours),
do: raise(DataValidationError, message: "Hours out of range: #{hours}")

defp assert_valid_minutes!(minutes) when minutes in 0..59, do: :ok

defp assert_valid_minutes!(minutes),
do: raise(DataValidationError, message: "Minutes out of range: #{minutes}")

defp assert_valid_seconds!(seconds) when seconds in 0..59, do: :ok

defp assert_valid_seconds!(seconds),
do: raise(DataValidationError, message: "Seconds out of range: #{seconds}")

defp assert_valid_fractional_seconds!(""), do: :ok

# Fractional seconds must not exceed 6 decimal digits, otherwise Postgres will round client's value.
Expand All @@ -777,9 +762,6 @@ defmodule Electric.Satellite.Serialization do
:ok
end

defp assert_valid_fractional_seconds!(val),
do: raise(DataValidationError, message: "Fractional seconds out of range: #{val}")

defp assert_float_in_range!(_num, :float8), do: :ok

defp assert_float_in_range!(num, :float4) do
Expand Down

0 comments on commit 6545a4e

Please sign in to comment.