Skip to content

Commit

Permalink
Address Kevin's PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
msfstef committed Apr 25, 2024
1 parent 32447d0 commit 6e183ae
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 26 deletions.
29 changes: 14 additions & 15 deletions clients/typescript/src/satellite/mock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,22 +164,21 @@ export class MockRegistry extends BaseRegistry {
const opts = { ...satelliteDefaults, ...overrides }

const satellites = this.satellites
const satellite = satellites[dbName]
if (satellite !== undefined) {
return satellite
} else {
const satellite = new MockSatelliteProcess(
dbName,
adapter,
migrator,
notifier,
socketFactory,
opts
)
await satellite.start()
this.satellites[dbName] = satellite
return satellite
if (satellites[dbName] !== undefined) {
return satellites[dbName]
}

const satellite = new MockSatelliteProcess(
dbName,
adapter,
migrator,
notifier,
socketFactory,
opts
)
this.satellites[dbName] = satellite
await satellite.start()
return satellite
}
}

Expand Down
4 changes: 2 additions & 2 deletions components/toolbar/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ In your code after calling `electrify`, if in debug mode, import and pass the el
const electric = await electrify(conn, schema, config)

if (config.debug) {
import('@electric-sql/debug-toolbar')
.then(({ addToolbar }) => addToolbar(electric))
const { addToolbar } = await import('@electric-sql/debug-toolbar')
addToolbar(electric)
}
```

Expand Down
3 changes: 1 addition & 2 deletions components/toolbar/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@
"jsdom": "24.0.0",
"prettier": "3.2.5",
"typescript": "^5.4.5",
"vitest": "^1.5.0",
"zod": "^3.23.3"
"vitest": "^1.5.0"
},
"peerDependencies": {
"electric-sql": "workspace:*"
Expand Down
7 changes: 0 additions & 7 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6e183ae

Please sign in to comment.