-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore (cli): extract cli to separate package #1317
Conversation
6e9670b
to
bd42a80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looks good! Left some minor comments mostly relating to having some way to share configs (eslint, prettier, tsconfig) and utilities (like fix-imports.js
) which can be addressed in a separate PR
@@ -0,0 +1,117 @@ | |||
import * as fs from 'fs' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: perhaps we also want to factor this out as a common utility between packages (although really I'd like us to find a way to not need this altogether haha) - maybe as an unpublished pnpm package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with Sam, i would prefer the use .js imports route. I might update all imports in the CLI package after rebasing and including the changes made to the CLI in concurrent PRs.
3fdaed6
to
8a7bfde
Compare
5f1b1a4
to
85716b2
Compare
d2f8080
to
2ebe05b
Compare
This PR extracts the CLI out of the
electric-sql
package and into its own@electric-sql/cli
package.TODO:
.js
extension to every import to avoid having to run thefix-imports.js
script.