chore (drivers): extract drivers to a separate package #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-dp
force-pushed
the
kevindp/vax-1903-extract-drivers
branch
6 times, most recently
from
b4deb74
to
13245fd
Compare
kevin-dp
force-pushed
the
kevindp/vax-1887-extract-cli
branch
from
d2f8080
to
2ebe05b
Compare
kevin-dp
force-pushed
the
kevindp/vax-1903-extract-drivers
branch
8 times, most recently
from
362ed3a
to
2d1f8a3
Compare
msfstef
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Looks great, nice work!
My only concern is with the extraction of some utilities, like the QualifiedTablename class, parseTableNames, and parseDate, which end up being core to the client as well but they belong to the drivers package, despite them only being used in tests or not used at all in the whole of the driver package.
I wonder if, since they are so few as well, we might benefit from keeping them in the client and re-implementing thinner abstractions for the drivers only?
…erwise we get subtle type compatibility issues.
… the compiled dist/bin.js file because pnpm install would fail if dist/bin.js does not exist but in order to build dist/bin.js we first need to pnpm install.
…iles on Node >=v18.19.0
…bleName and parseTablenames to ts-client package
kevin-dp
force-pushed
the
kevindp/vax-1903-extract-drivers
branch
from
0fd9737
to
ee33c9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.