fix: psql utility #1340
Open
fix: psql utility #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this seems to solve the problem where electric-sql psql doesn't connect successfully to the proxy url when it is not started via --with-postgres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported to @samwillis through electrify discord I discovered a problem with
electric-sql psqlutility that, if you didn't start the proxy withelectric-sql start --with-postgrestheelectric-sql psqlutility would fail to connect to the database. This PR adds a fallback that forces runs the connection using the host machine, still need to check if the host machine haspsqlinstalled to perform the connection, but I tested like this and it worked just fine. Before actually making that check I want to see the opinion of the owners of the project about this solution.