Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (client): extract sync API and make DAL optional #1355
feat (client): extract sync API and make DAL optional #1355
Changes from all commits
5139292
afe5917
e20610e
d5f322f
3831657
daddd6b
cd583e4
27ddfa3
1fa0b8a
e489f5b
62ff47f
884705f
12a9004
71a290e
bd343d0
e04cbe6
1e47213
94a1f6e
06f1475
1d8ae83
e27cfae
65ab817
1775eda
0f1bc3c
d9922e1
a6d1331
c00eefe
7a25b47
d4eeedf
8f0cf10
f2f3bc7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: not for this PR but I think we should really move to object arguments rather than positional haha