Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (client): drop the DAL and the generator #1392

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kevin-dp
Copy link
Contributor

This PR drops the DAL and the generator from the client.
DAL unit tests have been removed.
The remaining unit tests and e2e tests have been modified accordingly by replacing DAL queries by raw queries.

TODO:

  • Update website (docs)

Copy link

linear bot commented Jun 20, 2024

VAX-1940 Drop the DAL

@kevin-dp kevin-dp force-pushed the kevindp/vax-1940-drop-dal branch 3 times, most recently from 28d6579 to 423085e Compare June 24, 2024 10:20
@kevin-dp kevin-dp requested a review from msfstef June 24, 2024 11:18
@kevin-dp kevin-dp force-pushed the kevindp/vax-1931-extract-sync-and-raw branch from 7e612d2 to 692a12a Compare June 24, 2024 11:54
Copy link
Contributor

@msfstef msfstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice to see so many things being removed!

Should this PR also remove Zod as a dependency? Or are we still using it for schema validation with the minimal DB schema provided? I'm wondering if we are using it minimally if it might be worth doing a custom implementation of a thin schema validator for rows just for the sake of removing the problematic dependency.

clients/typescript/src/util/types.ts Outdated Show resolved Hide resolved
@kevin-dp
Copy link
Contributor Author

Looks good! Nice to see so many things being removed!

Should this PR also remove Zod as a dependency? Or are we still using it for schema validation with the minimal DB schema provided? I'm wondering if we are using it minimally if it might be worth doing a custom implementation of a thin schema validator for rows just for the sake of removing the problematic dependency.

We could make a follow-up PR that removes the Zod dependency altogether and replaces the usages of Zod by some custom validation code.

@kevin-dp kevin-dp force-pushed the kevindp/vax-1931-extract-sync-and-raw branch from b2f1f0f to f2f3bc7 Compare June 26, 2024 10:50
Base automatically changed from kevindp/vax-1931-extract-sync-and-raw to main June 26, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants