-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (client): drop the DAL and the generator #1392
base: main
Are you sure you want to change the base?
Conversation
28d6579
to
423085e
Compare
423085e
to
39841f6
Compare
7e612d2
to
692a12a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice to see so many things being removed!
Should this PR also remove Zod as a dependency? Or are we still using it for schema validation with the minimal DB schema provided? I'm wondering if we are using it minimally if it might be worth doing a custom implementation of a thin schema validator for rows just for the sake of removing the problematic dependency.
We could make a follow-up PR that removes the Zod dependency altogether and replaces the usages of Zod by some custom validation code. |
b2f1f0f
to
f2f3bc7
Compare
d3c569b
to
26aaecb
Compare
26aaecb
to
1f1a14f
Compare
This PR drops the DAL and the generator from the client.
DAL unit tests have been removed.
The remaining unit tests and e2e tests have been modified accordingly by replacing DAL queries by raw queries.
TODO: