fix(electric): Update SSL logic after upgrading to OTP 27.0 #1396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we upgraded the sync service to OTP 27.0, we missed the changed default from
verify_none
toverify_peer
in SSL connections.We now explicitly set
verify
toverify_none
because it's currently the only way to ensure encrypted connections work even when a faulty certificate chain is presented by the PG host. This behaviour matches that ofpsql <DATABASE_URL>?sslmode=require
.Here's an example of connecting to DigitalOcean's Managed PostgreSQL to illustrate the point:
Fix #1395.