Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (toolbar): modify drivers dependency to be a workspace dependency #1411

Merged
merged 2 commits into from
Jun 28, 2024
Merged

fix (toolbar): modify drivers dependency to be a workspace dependency #1411

merged 2 commits into from
Jun 28, 2024

Conversation

kevin-dp
Copy link
Contributor

No description provided.

alco
alco approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@alco alco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one caveat:

I have updated pnpm to version 9 on CI, and the pnpm-lockfile has been updated accordingly in main. Judging from the diff, you still have pnpm v6. Would you mind upgrading and reruning pnpm i to fix the lockfile diff?

@kevin-dp kevin-dp merged commit 31d8418 into main Jun 28, 2024
36 checks passed
@kevin-dp kevin-dp deleted the kevindp/fix-drivers-dep branch June 28, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alco alco alco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin-dp @alco